-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot use HttpServer with UDS #231
Comments
Note: for my testing purpose solved by:
Host is set to I've also noticed that the |
Thanks for filing this! This is an interesting issue, given that the underlying component does not currently support Unix domain sockets (UDS) (reactphp/socket#25) :-) I agree that despite this, this is still a minor bug that parsing the request should probably not fail in this case. Do you feel like filing a PR to fix (and test) this? Considering long-term goals, does it make sense to ignore |
@clue I've added a test. The problem at least on OSX seems to be related to a PHP bug with UDS that I've seen before (https://bugs.php.net/bug.php?id=74556). |
@andig Thanks for the update, I've just commented on this and linked to a related ticket (#234 (comment)) 👍 I wonder where this address you're seeing comes from, as this should already be handled by our socket component (reactphp/socket#100). Do you happen to use an older version or a custom implementation that does not implement the same fix? |
@clue I think the problem is that I'm using the unix socket on the server side, so the |
Thanks for the confirmation! As per reactphp/socket#25 there's currently no official If you're using a custom implementation, I would suggest re-using the existing logic to return semantically correct unix address strings. You should be able to re-use the logic from the above link and/or manually return As an alternative, once reactphp/socket#25 is resolves (PRs welcome!), we can add an integration test for this and make sure this works out of the box 👍 |
I've opened reactphp/socket#120, currently work in progress. This fixes the problem according to my testing. Shall we close this PR hence and focus on the proper UDS server? Big thank you for your patience and help! |
Nice! Also happy to hear this appears to fix the issue you're seeing! I think both ways make sense, so I'll leave the decision up to you. Either way, thank you for your continuous effort! :-) |
tl;dr Still needs reactphp/socket#123 to get in for Mac-specific failure on current PHP. |
PHP-PM uses UDS for handling master requests on slave. This fails in the
RequestHeaderParser
:ping @WyriHaximus can this constraint be removed to allow any type of underlying socket?
The text was updated successfully, but these errors were encountered: