Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyfills #116

Closed
flopes89 opened this issue Nov 4, 2017 · 5 comments
Closed

Polyfills #116

flopes89 opened this issue Nov 4, 2017 · 5 comments

Comments

@flopes89
Copy link

flopes89 commented Nov 4, 2017

First off: Awesome project, I'm really loving it. However, as I played around with it and opened it in IE11, it didn't work, so I dug around a bit, and found that despite the README says

Dynamic polyfills, courtesy of babel-preset-env

no actual (in my mind) polyfills were being used. When I think about polyfills, I would expect to find a babel-polyfill for things like Object.assign (that are used in this kit) somewhere.

Am I missing something important or is this just a minor oversight? Is there a problem with adding those polyfills to target "all" browers?

@klarstrup
Copy link
Contributor

I too noticed this was not enabled by default, gotta add useBuiltIns: "usage" to babel-preset-env settings. Maybe a PR is in order.

@leebenson
Copy link
Member

TBH, ReactQL could do with more testing in older browsers. Would certainly accept PRs.

@klarstrup
Copy link
Contributor

An overhaul of the babel deps and config might be due once Babel 7 comes out one of these days, too.

@flopes89
Copy link
Author

I opened a PR for this, #119 - further discussion there I guess?

@leebenson
Copy link
Member

Apologies for the generic response, but I've released a new v3.0 kit, which has been re-written from the ground up.

It bumps the ReactQL stack to Webpack 4, React 16.4, Apollo Client 2.0, and adds Styled Components, full SSR (even in development), and has been re-written in Typescript. It's leaner, faster and has been brought completely up-to-date.

If you're still using ReactQL (and I appreciate you may not be, given the time lag in my response), I'd recommend checking out the new kit to see if your issue has been answered. If not, please feel free to post a new issue at https://github.com/leebenson/reactql

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants