Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modal): Added static backdrop animation defined in Bootstrap 4.4 #1750

Merged
merged 2 commits into from
Jan 15, 2020
Merged

Conversation

kyletsang
Copy link
Member

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

An animation was added for static backdrop modals in Bootstrap 4.4. This can be demoed at the following url:
https://getbootstrap.com/docs/4.4/components/modal/#static-backdrop

In addition to this, I fixed the esc key from closing a modal when the backdrop is set to static as per docs:
https://getbootstrap.com/docs/4.4/components/modal/#options

Includes a modal-backdrop element. Alternatively, specify static for a backdrop which doesn't close the modal on click or on escape key press.

src/Modal.js Outdated Show resolved Hide resolved
@TheSharpieOne TheSharpieOne merged commit 7d44f36 into reactstrap:master Jan 15, 2020
@ALEUT
Copy link

ALEUT commented Jan 22, 2020

The behavior was changed since version 4.2.0: before I was able to close the modal using Esc button when keyboard={true} and backdrop="static", but now I can't. Is it expected?

@TheSharpieOne
Copy link
Member

Looks like it should allow esc to close the modal when keyboard is true. I opened a new issue to track this. Thanks you.

Also for reference: twbs/bootstrap#29978

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants