fix(Modal): map body class name before removing #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fantua
reviewed
Feb 9, 2018
src/Modal.js
Outdated
| const classes = document.body.className.replace(/(^| )modal-open( |$)/, ' '); | ||
| document.body.className = mapToCssModules(classNames(classes).trim(), this.props.cssModule); | ||
| setScrollbarWidth(this.originalBodyPadding); | ||
| if (!this.props.isOpen) { |
There was a problem hiding this comment.
Not a good check. In case that Modal never wasn't open before, it's still will removing class from body.
There was a problem hiding this comment.
Good catch. I ended up just resorting to keeping track of whether or not the instance added or removed the class. This way it will only ever add it if it isn't there and only remove it if it was added.
It won't prevent nested modals from adding duplicate classes to the class name, but it will ensure a single instance only contributes a single class and removes it. When all of the nested modals are closed, the body should have the same class as it did before the modals were opened.
jlaramie
pushed a commit
to jlaramie/reactstrap
that referenced
this pull request
Mar 9, 2018
This was referenced Mar 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #665, Closes #763