Road to 0.67

[lunaleaps]

The branch cut has happened.

01/19/22 Update

0.67.0 has been promoted to stable. See patch discussion for 0.67.1 here
We aim to cut 0.68 release branch next week. See rough schedule

12/14/21 Update

• We have released a 0.67.0-rc.6 that includes a minor fix (facebook/react-native@9cd4092)
• 0.67.0-rc.6 is our candidate for stable and we aim to release it in the beginning of 2022
• Let us know if you encounter any release issues

12/06/21 Update

• Given this blocking issue (Hermes 0.10 has invalid Bitcode facebook/hermes#649) in 0.67.0-rc.4, we will be releasing a 0.67.0-rc.5 today that will revert the Hermes 0.10 to get feedback to confirm it is an issue with Hermes 0.10.
• Regardless of the ongoing status of Hermes 0.10 has invalid Bitcode facebook/hermes#649, we are pushing back the release of 67 to next year and may or may not release with Hermes 0.9.

Notice

• Current release candidate: 0.67.0-rc.6
• Have an issue with current release candidate? File an issue and we will triage.
• Have a pick request for this release? Does it fall under our pick request qualifications? If so please create a PR against the 0.67-stable branch and comment with the PR link

Report form for testers

Copy paste this table into a dedicated comment and fill accordingly 🤗 (the 🙅‍♂️ = non applicable/not tested)

| Link to branch:              | [link here]()           |
| ---------------------------- | :---------------------- |
| **Project info**             |                         |
| Name                         | <add me>                |
| Starting RN version          | <add me, ex. RN 0.65.1> |
| Hermes on iOS                | yes/no                  |
| Hermes on Android            | yes/no                  |
| **Tested - iOS**             |                         |
| Fast Refresh                 | ✅/🚨/🙅‍♂️                 |
| Debug/dev build on Simulator | ✅/🚨/🙅‍♂️                 |
| Debug/dev build on Device    | ✅/🚨/🙅‍♂️                 |
| Production build             | ✅/🚨/🙅‍♂️                 |
| Chrome remote debugger       | ✅/🚨/🙅‍♂️                 |
| Hermes debugger              | ✅/🚨/🙅‍♂️                 |
| Flipper debugger             | ✅/🚨/🙅‍♂️                 |
| **Tested - Android**         |                         |
| Fast Refresh                 | ✅/🚨/🙅‍♂️                 |
| Debug/dev build on Emulator  | ✅/🚨/🙅‍♂️                 |
| Debug/dev build on Device    | ✅/🚨/🙅‍♂️                 |
| Production build             | ✅/🚨/🙅‍♂️                 |
| Chrome remote debugger       | ✅/🚨/🙅‍♂️                 |
| Hermes debugger              | ✅/🚨/🙅‍♂️                 |
| Flipper debugger             | ✅/🚨/🙅‍♂️                 |

Highlighted Changes in this release

• Checkout this Changelog PR

Release Process

Checklist

• Changelog PR
• Start a Google doc of blog post for release and invite contributors of release highlights to expand
• Follow up on release dependencies

When ready to publish stable

• Ship changelog
• Ship blog post
• Notify react-native-website to ship new version

Retrospective Topics

Release Status

Tracking 0.67.0-rc.7

Upon release

• When this patch is released, upgrade upgrade-helper

Blocking issues for releasing 0.67.0-rc.7

Picks for 0.67.0-rc.7

---

0.67.0-rc.6 (current, strong candidate for stable)

Upon release

• When this patch is released, upgrade upgrade-helper

Blocking issues for releasing 0.67.0-rc.6

• Fix error when pod has no IPHONEOS_DEPLOYMENT_TARGET facebook/react-native#32746

Picks for 0.67.0-rc.6

• Fix error when pod has no IPHONEOS_DEPLOYMENT_TARGET facebook/react-native@9cd4092

---

0.67.0-rc.5

Upon release

• When this patch is released, upgrade upgrade-helper

Blocking issues for releasing 0.67.0-rc.5

Picks for 0.67.0-rc.5

• Fix post_install_workaround downgrading development targets facebook/react-native@a4a3e67
• Revert Hermes 0.10
  • Hermes iOS: facebook/react-native@040e72e
  • Hermes Android: facebook/react-native@1d6af14

---

0.67.0-rc.4

Upon release

• When this patch is released, upgrade upgrade-helper

Blocking issues for releasing 0.67.0-rc.4

• • Hermes 0.10 fails the iOS App build process: Hermes 0.10 has invalid Bitcode facebook/hermes#649

Picks for 0.67.0-rc.4

1. Outstanding Hermes 0.10.0 release. The 0.10 Hermes release is currently blocked via Source code for latest version of Pod is not accessible to CocoaPods Trunk CocoaPods/trunk.cocoapods.org#320. Once unblocked, we will release it as a stable patch release.
   • Hermes iOS: facebook/react-native@040e72e
   • Hermes Android: facebook/react-native@1d6af14
2. Revert facebook/react-native@f3fe7a0 as it breaks EXTRA_PACKAGER_ARGS on iOS
   • Needs to be backported to main
3. Revert "Fix Deadlock in RCTi18nUtil (iOS) (#31032)" facebook/react-native@70ddf46

---

0.67.0-rc.3

Upon release

• When this patch is released, upgrade upgrade-helper

Blocking issues for releasing 0.67.0-rc.3

Picks for 0.67.0-rc.3

1. generated codegen files: facebook/react-native@5f7deb5
2. Fix npm latest tag when running patch update which needs:
   • Extract version parsing from release script: facebook/react-native@cc1e3ab
   • Clean up publish-npm.js and use parseVersion: facebook/react-native@029376c
   • Fix npm latest tag issue when releasing patches: facebook/react-native@68e6788
3. Revert jest preprocessor changes: facebook/react-native@74b91c5
4. Renames Keyboard.removeEventListener to Keyboard.removeListener: facebook/react-native@8880c09

---

0.67.0-rc.2

Upon release

• When this patch is released, upgrade upgrade-helper

Blocking issues for releasing 0.67.0-rc.2

• "error: thread-local storage is not supported for the current target" has re-occured: Apple Silicon (M1) troubleshooting guide (RN 0.64/0.65/0.66) facebook/react-native#31941 (comment) Fixed with pick 2

Picks for 0.67.0-rc.2

1. Load jsc or hermes lib in static method facebook/react-native@d839b24
2. Add back in __apply_Xcode_12_5_M1_post_install_workaround facebook/react-native@03a0907

---

0.67.0-rc.1

Upon release

• When this patch is released, upgrade upgrade-helper

Blocking issues for releasing 0.67.0-rc.1

• FBReactNativeSpec failure facebook/react-native#32417 Turned out to be non-issue

Picks for 0.67.0-rc.1

• facebook/react-native@1e6add1 from comments here: facebook/react-native@e18cf90#r58230816

[tido64]

I think these warnings are new in 0.67 when Flipper is enabled. I can't recall seeing them in 0.66.

ld: warning: duplicate symbol 'folly::detail::str_to_bool(folly::Range<char const*>*)' in:
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(Conv.o)
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(Conv.o)
ld: warning: duplicate symbol 'folly::makeConversionError(folly::ConversionCode, folly::Range<char const*>)' in:
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(Conv.o)
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(Conv.o)
ld: warning: duplicate symbol 'folly::exception_wrapper::from_exception_ptr(std::exception_ptr&&)' in:
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(ExceptionWrapper.o)
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(ExceptionWrapper.o)
ld: warning: duplicate symbol 'folly::exception_wrapper::from_exception_ptr(std::exception_ptr const&)' in:
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(ExceptionWrapper.o)
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(ExceptionWrapper.o)
ld: warning: duplicate symbol 'folly::exception_wrapper::onNoExceptionError(char const*)' in:
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(ExceptionWrapper.o)
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(ExceptionWrapper.o)
ld: warning: duplicate symbol 'folly::exceptionStr(folly::exception_wrapper const&)' in:
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(ExceptionWrapper.o)
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(ExceptionWrapper.o)
ld: warning: duplicate symbol 'folly::exception_wrapper::uninit_' in:
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(ExceptionWrapper.o)
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(ExceptionWrapper.o)
ld: warning: duplicate symbol 'folly::exception_wrapper::ExceptionPtr::ops_' in:
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(ExceptionWrapper.o)
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(ExceptionWrapper.o)
ld: warning: duplicate symbol 'folly::exception_wrapper::SharedPtr::ops_' in:
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/Flipper-Folly/libFlipper-Folly.a(ExceptionWrapper.o)
    /~/Library/Developer/Xcode/DerivedData/Example-cexoyqlacelygjcyhececofimwzz/Build/Products/Debug-iphonesimulator/RCT-Folly/libRCT-Folly.a(ExceptionWrapper.o)

Flipper still works though, so maybe it's not a cause for concern.

[mikehardy]

I think folly duplicate symbols is this: facebook/react-native#32333 (comment)

Apparently "dead code stripping" in build settings will get rid of the error, but has a tradeoff with debugging. There does not appear to be a root cause discovered yet.

[rnapier]

I don't believe this is the same issue. Flipper-Folly and RCT-Folly appear to be different versions of the same Folly library, so they define the same functions and collide. I believe this warning is correct and a problem. There should only be one Folly library in the system and RCT and Flipper should both use it, not bundle their own copies.

[mikehardy]

It appears that Expo uses an iOS minimum deployment version of 12? That came up in the M1 build troubleshooting issue, and it causes part of the iOS compile workaround hack to fail, my thoughts as typed out on facebook/react-native#31941 (comment)

---

Perhaps the time-redefinition-avoidance part of the Podfile compile hack - since it appears it will live longer then I/we thought it would could use a little refresh where it either takes a parameter of your ios deployment version, or attempts to dynamically detect it so that it is not quite so brittle. The assumption that target deployment version is 11 does fit most people, but if Expo is 12 there will be a huge percentage of users like yourself that are bitten by this

---

I don't have time right now to extend the hack and my ruby skills are a bit awful, but what are the thoughts on the idea though? I personally try not to hide too much magic in my hacks so I like the idea of specifying an optional argument (but defaulting to 11) for the workaround for existing users, along with a comment in the template above it saying # pass in your minimum deployment version here and alter the call in the template to have 11

That could un-break a lot of users and allow people on RN67 (and/or RN66 if it's backported) to use it more LTS-style even if their iPhone min version bumps up

[mikehardy]

Post a suggested edit to that PR for sure! I'd pursue the second compi error separately IMHO, logged issue/PR

[ZComwiz]

On further inspection, I see the difference in DoubleConversion in Folly that there was a switch from a precompiled ".a" file libFlipper-DoubleConversion.a back in RN 64 to the new xcFramework format so it may be related to just adding the command to create the MacCatalyst slices when making the xcframework and it will work. I don't have personal experience with xcFrameworks, but to whoever made the framework, from what I'm reading, it really should be a one-line command for them to patch.

[Yonom]

IMO it is a better idea to apply the fix to folly itself instead of bloating the m1 workaround function. For that, you'd need a PR on the folly repo: https://github.com/facebook/folly/blob/main/folly/portability/Time.h#L31

Not sure if your fix will make it to 0.67 (given that its not a regression from 0.66) but you could apply it via sed for the time being.

[mikehardy]

@ZComwiz no, building for macCatalyst is a little worse than that. I have some scar tissue from battling with it. But others can perhaps use it, if you propose this to the folly folks (I don't have time to carry it over there, sorry): transistorsoft/react-native-background-fetch#311 (comment)

That's a script I used in a proprietary production library, it worked.

Specifically note this section - if you don't flatten the directory structure produced by Xcode it will not work:

# Catalyst framework directory structure flattening step 1:
# - Copy the framework in a specific way: de-referencing symbolic links on purpose
echo "Installing framework into packages/react-native submodule"
rm -rf "${OUTPUT_FOLDER}/${FRAMEWORK_NAME}.xcframework" && \
  cp -rp "${FRAMEWORK_PATH}" "${OUTPUT_FOLDER}"

# Catalyst framework directory structure flattening step 2:
# - Remove the catalyst framework "Versions" directory structure after symbolic link de-reference
rm -rf "${OUTPUT_FOLDER}/${FRAMEWORK_NAME}.xcframework/ios-arm64_x86_64-maccatalyst/${FRAMEWORK_NAME}.framework/Versions"

[Yonom]

@lunaleaps facebook/react-native@a4a3e67 can this commit be picked for the next rc?

[elicwhite]

In the upgrade helper for 66.3 to 67 rc3, I see these files starting with underscores. Is that correct? I think I've seen other underscore files get renamed to have a dot as part of a release

[barbieri]

the rename of underline to dot is not automatic, we need to fix the react-native-cli to handle these as well

[mikehardy]

For unrelated reasons I was in this area yesterday and remembered this conversation. Here's the deep link in to the necessary patch site @barbieri https://github.com/react-native-community/cli/blob/cddb0c3fb06ef949ea689221c6167147af40e37f/packages/cli/src/tools/generator/copyProjectTemplateAndReplace.ts#L139-L150

[oblador]

Please revert facebook/react-native@f3fe7a0 as it breaks EXTRA_PACKAGER_ARGS on iOS.

[mikehardy]

That sounds serious @oblador ! I see no related issue https://github.com/facebook/react-native/issues?q=EXTRA_PACKAGER_ARGS - is anyone aware that even happened?

[oblador]

Originally reported here in October: facebook/react-native#31587 (comment)

[beetlebum]

I believe the Sentry integration breaks because of this change.

[lunaleaps]

This has been picked into 0.67.0-rc.4 and I have a diff to backport to main (D32734743)

[beetlebum]

After upgrading to 0.67-rc4 from 0.66, and uploading our iOS app into Testflight using Xcode 13.1 on an M1 Macbook Pro, I get an Invalid Bundle error:

TMS-90562: Invalid Bundle - The app cannot be processed because options not allowed to be embedded in bitcode are detected in the submission. It is likely that you are not building the app with the toolchain provided in Xcode. Rebuild your entire app with the latest GM Xcode and submit the app again.

Reverting the upgrade makes the problem go away. Also it works fine on the simulator.

This might be something specific to our app and honestly I don't know how to debug it, just posting in case anyone else has a similar issue or can help triaging. Thanks.

[mikehardy]

This was noticed and discussed! Sorry it hasn't been noted here. There was some discussion on the release-feedback group and I'll paste it in here for future folks. It is an active topic, has a timebox on it where the "can't fix it" resolution will be to point back to hermes 0.9.0, and is being worked on. Sorry for the trouble - follow here for status:

facebook/hermes#649

Until then use either react-native 0.67.0-rc.3 or (if you can?) point back to hermes 0.9.0 locally (but please put a big "warning" sign on that and make sure you test - there are no known incompatibilities but...caution)

[kelset]

Thanks Mike for replying here - I've added the link to the top of the main post so that it's more visible.

[kelset]

@beetlebum could you try the RC5 and let us know if the issue of the invalid bundle is addressed? It will help us scope what has been causing it

[beetlebum]

@kelset it's working now, no issues on Testflight

[lunaleaps]

Thank you @beetlebum for trying this out!

[sunkibaek]

Hi @lunaleaps , It seems the most recent rc release has been mistakenly named as 0.65.0 instead of 0.67.0:

https://github.com/facebook/react-native/releases/tag/v0.67.0-rc.5

[lunaleaps]

Fixed! Thanks!

[lunaleaps]

Discussion happening here: #6 (comment)
Resolving this comment for now, we can pick whatever fix into this RC later

[siddharth-kt]

@lunaleaps Kindly help us out with this issue in next release (facebook/react-native#21801), it's very old issue and still exist, many developers are facing it, since its very common requirement for most of the mobile applications.

Thankyou

[leotm]

i c what u mean by v old - Oct 15, 2018 holy smokes 💨

[mikehardy]

at the same time, I don't see any PRs on that issue that appear aimed at fixing it?

The way to get this fixed is to do the needful so that little graphic I pasted in there has a beautiful icon in it:

[siddharth-kt]

at the same time, I don't see any PRs on that issue that appear aimed at fixing it?

The way to get this fixed is to do the needful so that little graphic I pasted in there has a beautiful icon in it:

I understand but unfortunately I don't have much experience with Android Native (Java/Kotlin) so can't PR, I mentioned this issue here so that you guys can take note of this issue.

[mikehardy]

No PR? No pick. This thread is for picks to stable. https://github.com/facebook/react-native/wiki/Release-FAQ
We need PRs for changes that have merged to master or it's not the right place unfortunately.
If it's really important for your use case and you don't have the skills, it may be possible to fund a fix from someone with skills.

[siddharth-kt]

Ok, I got it.

[joe-sam]

Looks likes hermes 0.10.0 build issues on ios may have probably been due to floating point alignment issues with the bitcode and has been fixed with the branch merge Remove float cast flag in 0.10.0 branch #654 .
Might be worth looking at another intermediate rc if production builds are working now?

[kelset]

just to clarify, 0.67 will go ahead with Hermes 0.9

[natsunami-s]

@kelset does that mean that we should refrain from using Hermes 0.10 for the time being? I was planning to upgrade my project's react-native version to get the fix for Intl (issue #572 , PR #571 )

[kelset]

Yes - until a new version of Hermes comes out (it being either 0.10.1 or 0.11) you should avoid it. They merged the fix in the 0.10 branch but there hasn't been any new releases yet.

[bviebahn]

@natsunami-s If I understand correctly there is only a problem on ios. So if you have waited like me for the fix of the Intl API, which is so far only available on android anyway, I think there should be no problem. At least that's what I am doing and I've had no problems so far.

[miinos]

@bviebahn use 0.67.rc4. it is bundled with hermes 0.10.

[swrobel]

@lunaleaps thanks for the release! FYI, the release notes should be updated to point "full changelog here" to this url: https://github.com/facebook/react-native/blob/main/CHANGELOG.md#v0670

[kelset]

thanks - fixed