Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.74][RC6] decouple RCTBridge+Private from jsinspector-modern #190

Closed
philIip opened this issue Mar 29, 2024 · 1 comment
Closed

[0.74][RC6] decouple RCTBridge+Private from jsinspector-modern #190

philIip opened this issue Mar 29, 2024 · 1 comment
Assignees
@philIip
Labels
Type: Pick Request

Comments

@philIip
Copy link

philIip commented Mar 29, 2024

Target Branch(es)

0.74

Link to commit or PR to be picked

facebook/react-native#43708

Description

second attempt for #183

i realized my original pick request had a merge conflict, because PageTarget got renamed to HostTarget after 0.74. this pick is an identical change, but instead leaving the name as PageTarget.

original description

new debugger logic added in 0.74 implicitly imported a C++ library depending on boost into the public headers for anyone importing RCTBridge+Private, which is a common header imported by libraries. boost is hard to link correctly, so this has caused issues with libraries such as OP-SQLite (facebook/react-native#43204).
@huntie
Copy link
Member

huntie commented Apr 2, 2024

Merged ✅

@huntie huntie closed this as completed Apr 2, 2024
@github-project-automation github-project-automation bot moved this from Inbox to Done / Picked in React Native 0.74 Releases Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philIip philIip

Labels
Type: Pick Request
Projects
React Native 0.74 Releases
Status: Done / Picked
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huntie @philIip