Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version 0.74, npm WARN ERESOLVE overriding peer dependency #239

Closed
TonyFTannous opened this issue Apr 23, 2024 · 8 comments
Closed
Assignees

Comments

@TonyFTannous
Copy link

Old Version

0.73.7

New Version

0.74

Description

npm WARN ERESOLVE overriding peer dependency
npm WARN While resolving: eslint-plugin-jest@26.9.0
npm WARN Found: @typescript-eslint/eslint-plugin@6.21.0
npm WARN node_modules/@typescript-eslint/eslint-plugin
npm WARN @typescript-eslint/eslint-plugin@"^6.7.4" from @react-native/eslint-config@0.74.81
npm WARN node_modules/@react-native/eslint-config
npm WARN dev @react-native/eslint-config@"0.74.81" from the root project
npm WARN
npm WARN Could not resolve dependency:
npm WARN peerOptional @typescript-eslint/eslint-plugin@"^5.0.0" from eslint-plugin-jest@26.9.0
npm WARN node_modules/eslint-plugin-jest
npm WARN eslint-plugin-jest@"^26.5.3" from @react-native/eslint-config@0.74.81
npm WARN node_modules/@react-native/eslint-config
npm WARN
npm WARN Conflicting peer dependency: @typescript-eslint/eslint-plugin@5.62.0
npm WARN node_modules/@typescript-eslint/eslint-plugin
npm WARN peerOptional @typescript-eslint/eslint-plugin@"^5.0.0" from eslint-plugin-jest@26.9.0
npm WARN node_modules/eslint-plugin-jest
npm WARN eslint-plugin-jest@"^26.5.3" from @react-native/eslint-config@0.74.81
npm WARN node_modules/@react-native/eslint-config

Steps to reproduce

  1. create new app npx react-native@latest init AwesomeProject
  2. npm install

Affected Platforms

Build - MacOS

Output of npx react-native info

System:
  OS: macOS 14.4.1
  CPU: (8) arm64 Apple M1
  Memory: 70.09 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.12.2
    path: ~/.nvm/versions/node/v20.12.2/bin/node
  Yarn: Not Found
  npm:
    version: 10.5.0
    path: ~/.nvm/versions/node/v20.12.2/bin/npm
  Watchman:
    version: 2024.01.22.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.4
      - iOS 17.4
      - macOS 14.4
      - tvOS 17.4
      - visionOS 1.1
      - watchOS 10.4
  Android SDK:
    API Levels:
      - "28"
      - "29"
      - "31"
      - "33"
      - "34"
    Build Tools:
      - 29.0.2
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 33.0.0
      - 33.0.2
      - 33.0.3
      - 34.0.0
    System Images:
      - android-31 | Google APIs ARM 64 v8a
      - android-33 | Google APIs ARM 64 v8a
      - android-34 | Google APIs ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2023.2 AI-232.10300.40.2321.11668458
  Xcode:
    version: 15.3/15E204a
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.11
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.74.0
    wanted: 0.74.0
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs

N/A

Reproducer

https://reactnative.dev/docs/environment-setup

Screenshots and Videos

No response

@huntie
Copy link
Member

huntie commented Apr 24, 2024

@TonyFTannous Thanks for reporting. Can confirm this warning is introduced in 0.74.0. As far as I can tell, this does not block an npm install, but I'll see if we can successfully bring over the recent @typescript-eslint/eslint-plugin bump (facebook/react-native@91d7251) to fix this.

@huntie huntie moved this from Inbox to Triaged in React Native 0.74 Releases Apr 24, 2024
@huntie huntie moved this from Triaged to Inbox in React Native 0.74 Releases Apr 24, 2024
@robhogan
Copy link
Collaborator

FYI @huntie, there was already a pick request for this which we rejected as it was very late in the RC, but I didn't realise these warnings would be the consequence: #194

@kbqdev
Copy link

kbqdev commented May 29, 2024

Screenshot 2024-05-29 at 14 06 35
Version 0.74.1
More issues. OMG

@huntie
Copy link
Member

huntie commented Jun 4, 2024

Merged facebook/react-native#44764. This will ship in 0.74.2.

@kbqdev
Copy link

kbqdev commented Jun 6, 2024

Still exist. i'm trying create new project -> remove node_module package-lock.json -> npm install.
Still same 0.74.1

@cortinico
Copy link
Collaborator

Still same 0.74.1

This is fixed in 0.74.2

@kbqdev
Copy link

kbqdev commented Jun 15, 2024

Screenshot 2024-06-15 at 21 26 51 It's not

@cortinico
Copy link
Collaborator

Screenshot 2024-06-15 at 21 26 51 It's not

Your error message is different from the original one in the first post: ERESOLVE overriding peer dependency so yes it's solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done / Picked
Development

No branches or pull requests

5 participants