Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.74] Build visionos hermes binary on the CI #330

Closed
okwasniewski opened this issue Jun 21, 2024 · 4 comments
Closed

[0.74] Build visionos hermes binary on the CI #330

okwasniewski opened this issue Jun 21, 2024 · 4 comments
Labels
Type Pick Request Pick requests to include commits inside a React Native release

Comments

@okwasniewski
Copy link

Target Branch(es)

0.74

Link to commit or PR to be picked

facebook/react-native#44691

Description

This PR implements CI/CD for Hermes on visionOS. We want to provide react native visionOS users the ability to use prebuilts from a trusted source (in this case React Native).

This change won't affect any of RN source code but it makes sure that the shipped hermes binary for the next version includes visionOS slice.

Here is a corresponding cherry-pick PR to rn/0.74-stable branch: facebook/hermes@7701f77 to make sure everything works correctly.

@okwasniewski okwasniewski added the Type Pick Request Pick requests to include commits inside a React Native release label Jun 21, 2024
@okwasniewski
Copy link
Author

Here is the cherry-pick: facebook/react-native#45124

@Titozzz
Copy link
Collaborator

Titozzz commented Jul 1, 2024

FYI: this will be in 0.74.4 instead of 0.74.3 as its ready to go and we'd prefer having Riccardo (currently OOO) when we merge this.

@okwasniewski
Copy link
Author

@Titozzz That's fine for me, thanks

@Titozzz
Copy link
Collaborator

Titozzz commented Jul 22, 2024

picked !

@Titozzz Titozzz closed this as completed Jul 22, 2024
@github-project-automation github-project-automation bot moved this from Inbox to Done / Picked in React Native 0.74 Releases Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type Pick Request Pick requests to include commits inside a React Native release
Projects
Status: Done / Picked
Development

No branches or pull requests

2 participants