Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process should be more flexible and give the option to “compile” modules instead of bundling them #51

Open
JayPanoz opened this issue Jun 20, 2018 · 0 comments
Assignees
Labels
Feature request Indicates the issue is a feature request

Comments

@JayPanoz
Copy link
Collaborator

JayPanoz commented Jun 20, 2018

I'm submitting a feature request

Short description of the issue/suggestion:

The build process is currently all or nothing for user settings, you can only bundle, you can’t “compile” each module into a specific stylesheet.

What is the expected behaviour?

With HTTP2, it makes sense to break up CSS into smaller files e.g. user settings submodules. We should anticipate this need.

What is the current behaviour?

We’re currently bundling everything into the ReadiumCSS-after.css stylesheet.

What is the motivation / use case for changing the behaviour?

Implementers might prefer to append/remove styles for user settings on user interaction.

Do you know which CSS modules (stylesheets) are impacted?

This is limited to user settings.

Other information (e.g. related issues, suggestions how to fix, links for us to have context)

  • That’s probably for v1, and not the beta.
  • I would vastly prefer implementing that using good old gulp/grunt given how tedious Webpack or some others are at working with CSS – creates an awful lots of issues for people not familiar with the latter bunch.
@JayPanoz JayPanoz added the Feature request Indicates the issue is a feature request label Jun 20, 2018
@JayPanoz JayPanoz self-assigned this Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Indicates the issue is a feature request
Projects
None yet
Development

No branches or pull requests

1 participant