-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Margins are no longer settable #179
Comments
Copy from the mailing-list: I have just double-checked on my side (pulled fresh code from the As an alternative point of reference, iBooks renders reflowable EPUBs |
Neither Ric or myself could change the margins with the slider in the settings dialog. Therefore, the question is are the margins settable from the settings dialog? If not, I don't necessarily see this as bad or good but I think it should have been made more clear to Bill and Ric. It's a little bit of a radical departure from what we are currently doing. Based on our previous discussion, I assumed that the user would still be able to choose from a range of margins. Also, if we decide to go this route we should remove the margin slider from the settings dialog. |
In other words: the "margins" setting controls the fixed size of the border around each individual page. I feel that this setting would be more useful if larger values were allowed (right now the difference is hard to tell). Note that eventually, we should probably group this setting with other readiblity enhancements such as: The optimal width of a line of text within a given page is a separate problem altogether. The getWidthFactor() approach had severals flaws (refer to the links below), one of which was the inadequate shrinkage of text content. Right now, Readium achieves a layout similar to iBooks, based on a commonly-accepted threshold in print and web design (minimum and maximum number of characters, with assumption on font size). iBooks does go much higher in font size and consequently seems to have a separate threshold to avoid tiny line lengths (auto switch to single spread, instead of maintaining a double page spread in landscape mode). |
Attached "accessible EPUB3" screenshots, when using the minimum and maximum margin values from the settings dialog. The navigation toolbar and page buttons are hidden. PS: demo of a similar min/max width threshold pagination algorithm, switching to 3 columns on large displays: |
Follow-up to ReadiumJS conference call: We have v1+ issues for adding new "readability enhancements" features, such as line height, word spacing, etc. which can be eventually grouped with the margin setting. We also know that the settings dialog needs to be re-organised, features removed / hidden, etc. (e.g. keyboard shortcuts customiser, page transitions). |
Follow-up: there is one user feedback on the IDPF forum about the "margins" slider setting not presenting the same behaviour as before (as discussed above). Just as @rkwright asked, we need more information about screen size, browser window dimensions, font size, etc. (it may be that the user is forcing single page mode, expecting the text to stretch to most of the width of the screen) At any rate, if users wish to see larger runs of text across the screen (just like regular web pages that do not use optimal / conventional min-max width thresholds), then we may need to consider adding a new setting, or revamp the "margins" slider setting which currently affects only the fixed-size whitespace area around each page of text. |
Here, we need to do two things:
Right now these values are hard-coded, see: Some users prefer wide columns (even as far as full stretch on landscape displays), whilst others need to be able to constrain the horizontal runs of text to a reasonable distance (for accessibility reasons). Because of the broad variety of personal preferences / needs, it would be nice to expose the min-max customisation in the settings dialog of the Chrome extension. This could replace or supplement the existing "margins" slider referred-to in (1). |
Addressed via #498 |
Recent changes related to margins seems to remove the ability to change the margin size. Not sure if this is by-design. @danielweck is on holiday and he made those changes.
We need to determine if we will do auto-margins moving forward. If so, we need to remove the setting from the dialog. If not, we need to make them settable again.
The text was updated successfully, but these errors were encountered: