Should still return header if either user or password is set for basic

readmeio · Sep 8, 2017 · 1483691 · 1483691
1 parent 02debab
commit 1483691
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/packages/api-explorer-ui/__tests__/lib/configure-security.test.js b/packages/api-explorer-ui/__tests__/lib/configure-security.test.js
@@ -51,6 +51,23 @@ describe('configure-security', () => {
         components: { securitySchemes: { test: { type: 'basic' } } },
       }, values, { test: {} })).toEqual(false);
     });
+
+    test('should return with a header if user or password are not blank', () => {
+      const user = 'user';
+      const values = {
+        auth: { test: { user, password: '' } },
+      };
+
+      expect(configureSecurity({
+        components: { securitySchemes: { test: { type: 'basic' } } },
+      }, values, { test: {} })).toEqual({
+        type: 'headers',
+        value: {
+          name: 'Authorization',
+          value: `Basic ${new Buffer(`${user}:`).toString('base64')}`,
+        },
+      });
+    });
   });
 
   describe('type=oauth2', () => {

diff --git a/packages/api-explorer-ui/src/lib/configure-security.js b/packages/api-explorer-ui/src/lib/configure-security.js
@@ -14,7 +14,7 @@ module.exports = function configureSecurity(oas, values, scheme) {
 
   if (security.type === 'basic') {
     // Return with no header if user and password are blank
-    if (!(values.auth[key].user && values.auth[key].password)) return false;
+    if (!values.auth[key].user && !values.auth[key].password) return false;
 
     return harValue('headers', {
       name: 'Authorization',