Fix RDMD callout titles... (AGAIN 🎩) (#659)

readmeio · Apr 30, 2020 · 296ebeb · 296ebeb
1 parent 0238060
commit 296ebeb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/markdown/__tests__/__snapshots__/components.test.js.snap b/packages/markdown/__tests__/__snapshots__/components.test.js.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`Components Callout 1`] = `"<blockquote class=\\"callout callout_error\\" theme=\\"❗️\\"><h3 class=\\"callout-heading false\\"><span class=\\"callout-icon\\">❗️</span>Error Callout</h3><p>Lorem ipsum dolor.</p></blockquote>"`;
+exports[`Components Callout 1`] = `"<blockquote class=\\"callout callout_error\\" theme=\\"❗️\\"><h3 class=\\"callout-heading false\\"><span class=\\"callout-icon\\">❗️</span><p>Error Callout</p></h3><p>Lorem ipsum dolor.</p></blockquote>"`;
 
 exports[`Components Callout 2`] = `"<blockquote class=\\"callout callout_default\\" theme=\\"🎟\\"><h3 class=\\"callout-heading empty\\"><span class=\\"callout-icon\\">🎟</span></h3><p>Callout with no title or theme.</p></blockquote>"`;
 

diff --git a/packages/markdown/components/Callout/index.jsx b/packages/markdown/components/Callout/index.jsx
@@ -2,14 +2,16 @@ const React = require('react');
 const PropTypes = require('prop-types');
 
 const Callout = props => {
-  const { attributes, children, theme, title, icon } = props;
-  const content = children.splice(1);
+  let { children } = props;
+  const { attributes, theme, title, icon } = props;
+  const content = title ? children.splice(1) : children;
+  children = title ? children : '';
   return (
     // eslint-disable-next-line react/jsx-props-no-spreading
     <blockquote {...attributes} className={`callout callout_${theme}`} theme={icon}>
       <h3 className={`callout-heading ${!title && 'empty'}`}>
         <span className="callout-icon">{icon}</span>
-        {children.length >= 2 ? children : title}
+        {children}
       </h3>
       {(content.length && content) || (!title ? children : '')}
     </blockquote>