Add better support for when the oas file is missing servers

readmeio · Oct 2, 2018 · 912f9c5 · 912f9c5
1 parent 2958a6b
commit 912f9c5
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 7 deletions.
diff --git a/packages/api-explorer/__tests__/lib/Oas.test.js b/packages/api-explorer/__tests__/lib/Oas.test.js
@@ -24,6 +24,18 @@ test('should remove end slash from the server URL', () => {
   );
 });
 
+test('should default missing servers array to example.com', () => {
+  expect(new Oas({}).servers[0].url).toBe('https://example.com');
+});
+
+test('should default empty servers array to example.com', () => {
+  expect(new Oas({ servers: [] }).servers[0].url).toBe('https://example.com');
+});
+
+test('should default empty server object to example.com', () => {
+  expect(new Oas({ servers: [{}] }).servers[0].url).toBe('https://example.com');
+});
+
 describe('operation.getSecurity()', () => {
   const security = [{ auth: [] }];
 

diff --git a/packages/api-explorer/__tests__/lib/__snapshots__/Oas.test.js.snap b/packages/api-explorer/__tests__/lib/__snapshots__/Oas.test.js.snap
@@ -3,7 +3,13 @@
 exports[`operation() should return a default when no operation 1`] = `
 Operation {
   "method": "get",
-  "oas": Oas {},
+  "oas": Oas {
+    "servers": Array [
+      Object {
+        "url": "https://example.com",
+      },
+    ],
+  },
   "parameters": Array [],
   "path": "/unknown",
 }

diff --git a/packages/api-explorer/src/lib/Oas.js b/packages/api-explorer/src/lib/Oas.js
@@ -65,14 +65,18 @@ class Operation {
 
 class Oas {
   constructor(oas) {
-    if (oas.servers) {
-      let url = oas.servers[0].url;
+    // Setting up a default server url
+    oas.servers = oas.servers || [];
+    oas.servers[0] = oas.servers[0] || {};
+    oas.servers[0].url = oas.servers[0].url || 'https://example.com';
 
-      if (url[url.length - 1] === '/') {
-        url = url.slice(0, -1);
-      }
-      oas.servers[0].url = url;
+    let url = oas.servers[0].url;
+    // Stripping the '/' off the end
+    if (url[url.length - 1] === '/') {
+      url = url.slice(0, -1);
     }
+
+    oas.servers[0].url = url;
     Object.assign(this, oas);
   }