Add support for php without opening tag

readmeio · Aug 13, 2018 · 9a2b25a · 9a2b25a
1 parent 6808f36
commit 9a2b25a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/syntax-highlighter/codemirror.js b/packages/syntax-highlighter/codemirror.js
@@ -8,6 +8,7 @@ require('codemirror/mode/ruby/ruby');
 require('codemirror/mode/python/python');
 require('codemirror/mode/clike/clike');
 require('codemirror/mode/htmlmixed/htmlmixed');
+require('codemirror/mode/php/php');
 
 function esc(str) {
   return str.replace(/[<&]/g, ch => (ch === '&' ? '&amp;' : '&lt;'));
@@ -44,6 +45,7 @@ const modes = {
   kotlin: ['clike', 'text/x-kotlin'],
   liquid: 'htmlmixed',
   scss: 'css',
+  php: ['php', 'text/x-php'],
 };
 
 function getMode(lang) {

diff --git a/packages/syntax-highlighter/test/index.test.js b/packages/syntax-highlighter/test/index.test.js
@@ -43,6 +43,10 @@ test('should work for html', () => {
   );
 });
 
+test('should work for php without opening tag', () => {
+  expect(syntaxHighlighter('echo "Hello World";', 'php')).toContain('cm-keyword');
+});
+
 test('should work for kotlin', () => {
   expect(syntaxHighlighter('println("$index: $element")', 'kotlin')).toContain('cm-variable');
 });