Fix remaining lint issues

readmeio · Sep 8, 2017 · a064c57 · a064c57
1 parent 10942cf
commit a064c57
Show file tree

Hide file tree

Showing 8 changed files with 38 additions and 423 deletions.
diff --git a/lerna-debug.log b/lerna-debug.log
diff --git a/packages/api-explorer-ui/src/block-types/api-header.jsx b/packages/api-explorer-ui/src/block-types/api-header.jsx
@@ -27,7 +27,7 @@ const ApiHeader = ({ block }) => {
 ApiHeader.propTypes = {
   block: PropTypes.shape({
     data: PropTypes.shape({
-      type: PropTypes.string.isRequired,
+      type: PropTypes.string,
       title: PropTypes.string.isRequired,
     }),
   }).isRequired,

diff --git a/packages/api-explorer-ui/src/block-types/callout.jsx b/packages/api-explorer-ui/src/block-types/callout.jsx
@@ -85,7 +85,7 @@ CallOut.propTypes = {
     data: PropTypes.shape({
       type: PropTypes.string.isRequired,
       title: PropTypes.string.isRequired,
-      body: PropTypes.array.isRequired,
+      body: PropTypes.array,
     }),
   }).isRequired,
 };

diff --git a/packages/api-explorer-ui/src/block-types/code.jsx b/packages/api-explorer-ui/src/block-types/code.jsx
@@ -11,8 +11,10 @@ const BlockCode = ({ data, opts = {} }) => {
 
   return (
     <span>
-      { opts.label && <hlabel>{opts.label}</hlabel> }
-
+      {
+        // eslint-disable-next-line jsx-a11y/label-has-for
+        opts.label && <label>{opts.label}</label>
+      }
       <div className="magic-block-code">
         {(!opts.hideHeaderOnOne || data.codes.length > 1) && (
           <ul className="block-code-header">
@@ -21,6 +23,7 @@ const BlockCode = ({ data, opts = {} }) => {
                 <li>
                   <a href="" onClick={`showCode${i}`} style={`active: ${i === 'tab'} `}>
                     {
+                      //eslint-disable-next-line
                       code.status ? (
                         <span>
                           <span className={`status-icon status-icon-${statusCodes(code.status)[2]}`} />
@@ -38,7 +41,7 @@ const BlockCode = ({ data, opts = {} }) => {
 
         <div className="block-code-code">
           {
-            data.codes.map((code, i) => (
+            data.codes.map(code => (
               <pre>
                 <code>{syntaxHighlighter(code.code, code.language, opts.dark)}</code>
               </pre>

diff --git a/packages/api-explorer-ui/src/block-types/content.jsx b/packages/api-explorer-ui/src/block-types/content.jsx
@@ -12,7 +12,7 @@ const PropTypes = require('prop-types');
 
 const parseBlocks = require('../lib/parse-magic-blocks');
 
-const Loop = ({ content }) => {
+const Loop = ({ content, column }) => {
   const elements = content.map((block) => {
     switch (block.type) {
       case 'textarea':
@@ -84,15 +84,15 @@ const Opts = (props) => {
 
 
 Loop.propTypes = {
-  block: PropTypes.shape({
+  content: PropTypes.arrayOf(PropTypes.shape({
     type: PropTypes.string.isRequired,
-  }).isRequired,
-  content: PropTypes.shape({}).isRequired,
+  })).isRequired,
+  column: PropTypes.string.isRequired,
 };
 
 Opts.propTypes = {
   'is-three-column': PropTypes.bool.isRequired,
-  body: PropTypes.shape({}).isRequired,
+  body: PropTypes.string.isRequired,
 };
 
 module.exports = Opts;
diff --git a/packages/api-explorer-ui/src/block-types/embed.jsx b/packages/api-explorer-ui/src/block-types/embed.jsx
@@ -28,8 +28,8 @@ Embed.propTypes = {
       html: PropTypes.string.isRequired,
       url: PropTypes.string.isRequired,
       favicon: PropTypes.string.isRequired,
-      width: PropTypes.string.isRequired,
-      height: PropTypes.string.isRequired,
+      width: PropTypes.string,
+      height: PropTypes.string,
       title: PropTypes.string.isRequired,
     }),
   }).isRequired,

diff --git a/packages/api-explorer-ui/src/block-types/image.jsx b/packages/api-explorer-ui/src/block-types/image.jsx
@@ -8,7 +8,7 @@ const ImageBlock = ({ image }) => {
   const border = image.border ? image.border : '';
 
   return (
-    <div>
+    <div className="magic-block-image">
       {
           (image && image.image && image.image.length) && (
             <div>
@@ -49,10 +49,10 @@ ImagesBlock.propTypes = {
 
 ImageBlock.propTypes = {
   image: PropTypes.shape({
-    sizing: PropTypes.string.isRequired,
-    border: PropTypes.string.isRequired,
+    sizing: PropTypes.string,
+    border: PropTypes.string,
     image: PropTypes.array.isRequired,
-    caption: PropTypes.string.isRequired,
+    caption: PropTypes.string,
   }).isRequired,
 };
 

diff --git a/packages/api-explorer-ui/src/block-types/parameters.jsx b/packages/api-explorer-ui/src/block-types/parameters.jsx
@@ -44,11 +44,11 @@ const Parameters = ({ block }) => {
           {
             (block.data.data['h-0'] || block.data.data['h-1']) && (
               <div className="tr">
-                {Th}
+                {Th()}
               </div>
             )
           }
-          {Tr}
+          {Tr()}
 
         </div>
       </div>
-Original file line number
+Diff line change
@@ Expand Up / @@ -44,11 +44,11 @@ const Parameters = ({ block }) => { @@
               {
                 (block.data.data['h-0'] || block.data.data['h-1']) && (
                   <div className="tr">
-                    {Th}
+                    {Th()}
                   </div>
                 )
               }
-              {Tr}
+              {Tr()}
             </div>
           </div>
@@ Expand Down @@