fix: setting a unique idPrefix for all forms to prevent dupe DOM IDs (#…

…544) * fix: setting a unique idPrefix for all forms to prevent dupe DOM IDs * test: fixing some broken tests
readmeio · Mar 20, 2020 · b8a5ee2 · b8a5ee2
1 parent b88a96b
commit b8a5ee2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/api-explorer/__tests__/Params.test.jsx b/packages/api-explorer/__tests__/Params.test.jsx
@@ -162,7 +162,7 @@ test('additionalProperties object labels (keys) should be editable', () => {
     [ADDITIONAL_PROPERTY_FLAG]: true,
   });
 
-  expect(params.find('input#createPath_a-key')).toHaveLength(1);
+  expect(params.find('input#body-createPath_a-key')).toHaveLength(1);
 });
 
 test('if no operationId is present, one should be generated', () => {
@@ -414,7 +414,7 @@ describe('readOnly', () => {
         <div>
           <Params {...props} operation={oas.operation('/pet', 'post')} />
         </div>
-      ).find('input#addPet_id[type="hidden"]')
+      ).find('input#body-addPet_id[type="hidden"]')
     ).toHaveLength(1);
   });
 });

diff --git a/packages/api-explorer/src/Params.jsx b/packages/api-explorer/src/Params.jsx
@@ -73,7 +73,7 @@ function Params({
               }}
               formData={formData[schema.type]}
               id={`form-${schema.type}-${operationId}`}
-              idPrefix={operationId}
+              idPrefix={`${schema.type}-${operationId}`}
               onChange={form => {
                 return onChange({ [schema.type]: form.formData });
               }}