Make sure manual examples are shown even if x-samples-enabled: false

readmeio · Aug 17, 2018 · dbca3a5 · dbca3a5
1 parent 47326f5
commit dbca3a5
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/packages/api-explorer/__tests__/CodeSample.test.jsx b/packages/api-explorer/__tests__/CodeSample.test.jsx
@@ -84,6 +84,34 @@ describe('code examples', () => {
     expect(codeSample.find('pre.tomorrow-night.tabber-body').length).toBe(1);
   });
 
+  test('should display custom examples even if SAMPLES_ENABLED is false', () => {
+    const docProps = {
+      setLanguage: () => {},
+      operation: new Operation({}, '/pet/{id}', 'get'),
+      language: 'node',
+      examples: [
+        {
+          language: 'javascript',
+          code: 'console.log(1);',
+        },
+      ],
+    };
+    const codeSample = shallow(
+      <CodeSample
+        {...docProps}
+        oas={
+          new Oas({
+            [extensions.SAMPLES_ENABLED]: false,
+            servers: [{ url: 'http://example.com' }],
+          })
+        }
+      />,
+    );
+
+    expect(codeSample.find('.code-sample-body').length).toBe(1);
+    expect(codeSample.find('pre.tomorrow-night.tabber-body').length).toBe(1);
+  });
+
   test('should not error if no code given', () => {
     const docProps = {
       setLanguage: () => {},

diff --git a/packages/api-explorer/src/CodeSample.jsx b/packages/api-explorer/src/CodeSample.jsx
@@ -63,10 +63,10 @@ class CodeSample extends React.Component {
     return (
       <div className="code-sample tabber-parent">
         {(() => {
+          if (examples.length) return this.renderExamples(examples, setLanguage);
           if (!oas[extensions.SAMPLES_ENABLED]) {
             return <div className="hub-no-code">No code samples available</div>;
           }
-          if (examples.length) return this.renderExamples(examples, setLanguage);
           const { snippet, code } = generateCodeSnippet(oas, operation, formData, language);
           return (
             <div>