Skip to content
This repository was archived by the owner on Nov 28, 2022. It is now read-only.

Commit dbca3a5

Browse files
author
Dom Harrington
committed
Make sure manual examples are shown even if x-samples-enabled: false
1 parent 47326f5 commit dbca3a5

File tree

2 files changed

+29
-1
lines changed

2 files changed

+29
-1
lines changed

packages/api-explorer/__tests__/CodeSample.test.jsx

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,34 @@ describe('code examples', () => {
8484
expect(codeSample.find('pre.tomorrow-night.tabber-body').length).toBe(1);
8585
});
8686

87+
test('should display custom examples even if SAMPLES_ENABLED is false', () => {
88+
const docProps = {
89+
setLanguage: () => {},
90+
operation: new Operation({}, '/pet/{id}', 'get'),
91+
language: 'node',
92+
examples: [
93+
{
94+
language: 'javascript',
95+
code: 'console.log(1);',
96+
},
97+
],
98+
};
99+
const codeSample = shallow(
100+
<CodeSample
101+
{...docProps}
102+
oas={
103+
new Oas({
104+
[extensions.SAMPLES_ENABLED]: false,
105+
servers: [{ url: 'http://example.com' }],
106+
})
107+
}
108+
/>,
109+
);
110+
111+
expect(codeSample.find('.code-sample-body').length).toBe(1);
112+
expect(codeSample.find('pre.tomorrow-night.tabber-body').length).toBe(1);
113+
});
114+
87115
test('should not error if no code given', () => {
88116
const docProps = {
89117
setLanguage: () => {},

packages/api-explorer/src/CodeSample.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ class CodeSample extends React.Component {
6363
return (
6464
<div className="code-sample tabber-parent">
6565
{(() => {
66+
if (examples.length) return this.renderExamples(examples, setLanguage);
6667
if (!oas[extensions.SAMPLES_ENABLED]) {
6768
return <div className="hub-no-code">No code samples available</div>;
6869
}
69-
if (examples.length) return this.renderExamples(examples, setLanguage);
7070
const { snippet, code } = generateCodeSnippet(oas, operation, formData, language);
7171
return (
7272
<div>

0 commit comments

Comments
 (0)