fix: bug where responses with multiple examples weren't rendered prop…

…erly (#599)
readmeio · Apr 13, 2020 · ef18f54 · ef18f54
1 parent c40a910
commit ef18f54
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/packages/api-explorer/__tests__/lib/create-code-shower.test.js b/packages/api-explorer/__tests__/lib/create-code-shower.test.js
@@ -103,21 +103,15 @@ describe('createCodeShower', () => {
               {
                 label: 'cat',
                 code: encodeJsonExample({
-                  summary: 'An example of a cat',
-                  value: {
-                    name: 'Fluffy',
-                    petType: 'Cat',
-                  },
+                  name: 'Fluffy',
+                  petType: 'Cat',
                 }),
               },
               {
                 label: 'dog',
                 code: encodeJsonExample({
-                  summary: "An example of a dog with a cat's name",
-                  value: {
-                    name: 'Puma',
-                    petType: 'Dog',
-                  },
+                  name: 'Puma',
+                  petType: 'Dog',
                 }),
               },
             ],

diff --git a/packages/api-explorer/src/lib/create-code-shower.js b/packages/api-explorer/src/lib/create-code-shower.js
@@ -43,9 +43,18 @@ function getMultipleExamples(response, lang) {
 
   const { examples } = response.content[lang];
   return Object.keys(examples).map(key => {
+    let example = examples[key];
+    if (typeof example === 'object') {
+      if ('value' in example) {
+        example = example.value;
+      }
+
+      example = JSON.stringify(example, undefined, 2);
+    }
+
     return {
       label: key,
-      code: typeof examples[key] === 'object' ? JSON.stringify(examples[key], undefined, 2) : examples[key],
+      code: example,
     };
   });
 }