Make oas.prepareSecurity() just return an empty object instead of null

Author: Dom Harrington

packages/api-explorer-ui/__tests__/lib/Oas.test.js

@@ -171,18 +171,18 @@ describe('operation.prepareSecurity()', () => {
 
   test('should throw if attempting to use a non-existent scheme');
 
-  test('should return null if no security', () => {
+  test('should return empty object if no security', () => {
     const operation = new Oas(multipleSecurities).operation('/no-auth', 'post');
-    expect(operation.prepareSecurity()).toBe(null);
+    expect(Object.keys(operation.prepareSecurity()).length).toBe(0);
   });
 
-  test('should return null if security scheme doesnt exist', () => {
+  test('should return empty object if security scheme doesnt exist', () => {
     const operation = new Oas(multipleSecurities).operation('/unknown-scheme', 'post');
-    expect(operation.prepareSecurity()).toBe(null);
+    expect(Object.keys(operation.prepareSecurity()).length).toBe(0);
   });
 
-  test('should return null if security scheme type doesnt exist', () => {
+  test('should return empty if security scheme type doesnt exist', () => {
     const operation = new Oas(multipleSecurities).operation('/unknown-auth-type', 'post');
-    expect(operation.prepareSecurity()).toBe(null);
+    expect(Object.keys(operation.prepareSecurity()).length).toBe(0);
   });
 });

packages/api-explorer-ui/src/AuthBox.jsx

@@ -62,7 +62,7 @@ class AuthBox extends React.Component {
   render() {
     const { authInputRef, operation, onSubmit, open, needsAuth, toggle } = this.props;
 
-    if (!operation.prepareSecurity()) return null;
+    if (Object.keys(operation.prepareSecurity()).length === 0) return null;
 
     return (
       <div className={classNames('hub-auth-dropdown', 'simple-dropdown', { open })}>

packages/api-explorer-ui/src/lib/Oas.js

@@ -15,10 +15,6 @@ class Operation {
   prepareSecurity() {
     const securityRequirements = this.getSecurity();
 
-    if (!securityRequirements.length) {
-      return null;
-    }
-
     return securityRequirements
       .map(requirement => {
         let keys;
@@ -62,9 +58,6 @@ class Operation {
           if (!prev[security.type]) prev[security.type] = [];
           prev[security.type].push(security.security);
         });
-        if (Object.keys(prev).length === 0) {
-          return null;
-        }
         return prev;
       }, {});
   }