Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

feat(api explorer): adding optional handler for auth group change #1054

Merged
merged 2 commits into from
Nov 19, 2020
Merged

feat(api explorer): adding optional handler for auth group change #1054

merged 2 commits into from
Nov 19, 2020

Conversation

dpim
Copy link
Contributor

@dpim dpim commented Nov 18, 2020

🧰 What's being changed?

  • Adding support for passing an optional function to handle group change via props (which is called in addition to existing, built-in behavior).
  • This function would receive the new group member id whenever onAuthGroupChange() is invoked.

🧪 Testing

  • Manually verified

@dpim dpim requested a review from erunion November 18, 2020 23:20
@erunion erunion requested a review from Dashron November 18, 2020 23:21
@erunion erunion added the type:enhancement A potential new feature to be added, or an improvement we could make label Nov 18, 2020
erunion
erunion approved these changes Nov 19, 2020
View reviewed changes
packages/api-explorer/src/index.jsx Outdated Show resolved Hide resolved
Dashron
Dashron suggested changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@Dashron Dashron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmk what you think of Jon and my comments.

@erunion erunion merged commit f61142b into next Nov 19, 2020
@erunion erunion deleted the feat/ongroupchangehandler branch November 19, 2020 05:20
@erunion
Copy link
Member

erunion commented Nov 19, 2020

@dpim I'll cut a release with this later this week for you.

Dashron
Dashron reviewed Nov 19, 2020
View reviewed changes
Copy link
Contributor

@Dashron Dashron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Dashron Dashron Dashron requested changes

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
type:enhancement A potential new feature to be added, or an improvement we could make
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpim @erunion @Dashron