This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
fix: only access the proxy-enabled extension if we need to #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gratcliff
reviewed
Dec 7, 2020
| // TODO look to move this to Oas class as well | ||
| if (proxyEnabled && opts.proxyUrl) { | ||
| har.url = `https://try.readme.io/${har.url}`; | ||
| if (opts.proxyUrl) { |
There was a problem hiding this comment.
Do we not need to check for proxyEnabled any longer?
There was a problem hiding this comment.
proxyEnabled was the result of the getExtension call and is still in use on line 85.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
@readme/oas-to-harto only look for thex-proxy-enabledOAS extension if the option to do so has been passed into the library.