Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

refactor: use nanoid instead of shortid #1095

Merged
merged 1 commit into from
Dec 11, 2020
Merged

refactor: use nanoid instead of shortid #1095

merged 1 commit into from
Dec 11, 2020

Conversation

darrenyong
Copy link
Contributor

@darrenyong darrenyong commented Dec 9, 2020

🧰 What's being changed?

🎫 Asana Task

shortid has been deprecated. They recommend using nanoid β€” this just swaps shortid with nanoid.

πŸ§ͺ Testing

Click on the Add button for those params to make sure you can add rows.

  1. Open up the local environment
  2. Open a Swagger file that has object and array type parameters. types.json is a good one cause it will have all different types of params!
  3. Find any parameter that requires you to Add a row of input like array of strings or array of objects.
  4. Click Add! If you can add rows, it should be good to go πŸ˜„

[shortid has been deprecated] (https://www.npmjs.com/package/shortid). they recommend nanoid
@darrenyong darrenyong requested a review from erunion December 9, 2020 00:35
@erunion erunion requested a review from Dashron December 9, 2020 00:36
@erunion erunion added the type:refactor Issues about tackling technical debt label Dec 9, 2020
@Dashron
Copy link
Contributor

Dashron commented Dec 10, 2020

Darren pointed me to http://localhost:9966/?selected=swagger-files%2Ftypes.json which seems to work great.

@erunion erunion merged commit 2479089 into next Dec 11, 2020
@erunion erunion deleted the refactor/use-nanoid branch December 11, 2020 22:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:refactor Issues about tackling technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants