Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

fix: stop rendering array keys in json content #1177

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Conversation

erunion
Copy link
Member

@erunion erunion commented Feb 8, 2021

☁️   CI App

🧰 What's being changed?

This updates react-json-view to take advantage of the new displayArrayKey prop that allows us to hide array keys in JSON content from being rendered.

🧬 Testing

Before:

Screen Shot 2021-02-08 at 9 13 22 AM

After:

Screen Shot 2021-02-08 at 9 13 17 AM

@erunion erunion added the type:bug Something isn't working label Feb 8, 2021
@erunion erunion requested review from Dashron and darrenyong February 8, 2021 17:31
@erunion erunion temporarily deployed to readme-api-e-feat-hide--rwr6cj February 8, 2021 17:31 Inactive
Copy link
Contributor

@Dashron Dashron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks so much better

Copy link
Contributor

@darrenyong darrenyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! I know some customers were wondering why we were showing the index so they'll be happy 👍

@erunion erunion merged commit 5384bd3 into next Feb 10, 2021
@erunion erunion deleted the feat/hide-array-keys branch February 10, 2021 23:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants