Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

fix: missing operation schema exceptions #1180

Merged
merged 2 commits into from
Feb 10, 2021

Conversation

erunion
Copy link
Member

@erunion erunion commented Feb 10, 2021

☁️   CI App

🧰 What's being changed?

  • Updates our oas dependency to fix a bug where if a supplied path+method combination didn't exist in an OAS it was being searched for in though we'd still return an instance of the Operation class, we'd return it with an undefined schema property. This error would then cascase and throw failures on any accessor of that class. Check out fix: operation being set to undefined if not found oas#371 for tests.

🧬 Testing

Check out the attached manual-api-missingInOas.json example definition.

Against next, this is what it currently looks like:

Screen Shot 2021-02-09 at 6 56 39 PM

And with this fix:

Screen Shot 2021-02-09 at 6 58 14 PM

@erunion erunion added the type:bug Something isn't working label Feb 10, 2021
@erunion erunion temporarily deployed to readme-api-e-fix-missin-zn2gfh February 10, 2021 02:58 Inactive
Copy link
Contributor

@rafegoldberg rafegoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not as looped in on this, but the code looks good to me!

@billhimmelsbach billhimmelsbach self-requested a review February 10, 2021 03:04
Copy link

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Screen Shot 2021-02-09 at 7 03 13 PM

@erunion erunion merged commit cc4daaf into next Feb 10, 2021
@erunion erunion deleted the fix/missing-operation-schema-exceptions branch February 10, 2021 03:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants