This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
feat: adding support for server variables into oas-to-har #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
the
type:enhancement
ilias-t
reviewed
Mar 30, 2021
| }; | ||
|
|
||
| // If the incoming `server.variables` is missing variables let's pad it out with defaults. | ||
| formData.server.variables = { |
There was a problem hiding this comment.
nit: should we just move up into the object above or was this done to improve readability?
There was a problem hiding this comment.
Since I'm loading values in as ...values above I don't have a clean way to re-fill server.variables with defaults if they're missing in the block above this.
ilias-t
approved these changes
Mar 30, 2021
| - `cookie` | ||
| - `formData` | ||
| - `header` | ||
| - `server` — If the supplied OAS has multiple severs or server variables you can use this to set which server and variables to use. Shape of it should be: `{ selected: Integer, variables: { ...key-values }}`. `selected` should coorespond to index of the `servers` array in your OAS. |
Dashron
approved these changes
Mar 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
oas-to-har.oas-to-harREADME.🧬 Testing
See supplied unit tests.