Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

fix(code snippets): align curl params in code snippets correctly #1320

Merged
merged 3 commits into from
Jun 11, 2021

Conversation

thenaomiday
Copy link
Contributor

@thenaomiday thenaomiday commented Jun 11, 2021

☁️   CI App

🧰 What's being changed?

Get curl params to line up with one another:

Before:
Screen Shot 2021-06-11 at 10 06 54 AM

After:
Screen Shot 2021-06-11 at 10 06 29 AM

Fixes RM-740!

🧬 Testing

If the curl params line up correctly rather than being offset to the left, this has worked!

@erunion erunion temporarily deployed to explorer-pr-1320 June 11, 2021 20:15 Inactive
@thenaomiday thenaomiday requested a review from erunion June 11, 2021 20:29
@thenaomiday
Copy link
Contributor Author

@erunion these tests fail here but locally they're fine and when I try to update the snapshot locally nothing happens (as in, it seems up to date). any ideas?

@linear
Copy link

linear bot commented Jun 11, 2021

RM-740 Curl params don't line up

image.png

We should have these line up with each other!

@erunion erunion temporarily deployed to explorer-pr-1320 June 11, 2021 21:24 Inactive
@erunion erunion temporarily deployed to explorer-pr-1320 June 11, 2021 21:38 Inactive
@erunion erunion merged commit 34039e2 into main Jun 11, 2021
@erunion erunion deleted the chore/curl-snippet-spacing branch June 11, 2021 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants