This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Expanding our support for integer formats to a wider variety. #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
type:bug
kanadgupta
approved these changes
Aug 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a current problem in the explorer with our integer
formatsupport where we're misidentifyinguint64asint32. This resolves that, as well as expands our support to the following integer formats:int8uint8int16uint16uint32uint64Ideally, we wouldn't need to hardcode these kinds of things in here, but the TSC is working through some proposals on a format registry to the spec.