-
Notifications
You must be signed in to change notification settings - Fork 23
Bump node-fetch from 2.0.0-alpha.9 to 2.6.0 #280
Conversation
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.0.0-alpha.9 to 2.6.0. - [Release notes](https://github.com/bitinn/node-fetch/releases) - [Changelog](https://github.com/bitinn/node-fetch/blob/master/CHANGELOG.md) - [Commits](node-fetch/node-fetch@v2.0.0-alpha.9...v2.6.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
13c0473
to
b32e92f
Compare
expect((await parseResponse(har, new Response(responseBody))).type).toEqual(null); | ||
test('should autodetect a content-type if content-type header missing', async () => { | ||
expect((await parseResponse(har, new Response(responseBody))).type).toEqual( | ||
'text/plain;charset=UTF-8', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
node-fetch now defaults to doing auto-detection on response bodies, so a null content type should never be returned here in our test case.
@domharrington @kanadgupta Can yall take a look at this? There are a few major changes in node-fetch where it'll no longer return a |
@dependabot rebase |
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look a this just now, and the only places i can see .type
being used are here:
result.type && contentTypeIsJson(result.type) && typeof result.responseBody === 'object'; |
and here:
{syntaxHighlighter(result.responseBody, result.type)} |
I wonder if passing 'text/plain;charset=UTF-8'
into the syntax-highligher will work?
Looking at our code for this, if someone returns JSON but no content-type, then we'll render with no syntax highlighting. I'm not sure if that's the same as now, or whether this will be a regression. api-explorer/packages/api-explorer/src/lib/parse-response.js Lines 14 to 27 in d8da27f
|
@domharrington Ignoring that this is actually HTML, but syntax-highlighter can render So if we don't get back a content type now, node-fetch defaulting to that should be fine. |
Bumps node-fetch from 2.0.0-alpha.9 to 2.6.0.
Release notes
Sourced from node-fetch's releases.
Changelog
Sourced from node-fetch's changelog.
Commits
95286f5
v2.6.0 (#638)bf8b4e8
Allow agent option to be a function (#632)0c2294e
2.5.0 release (#630)0fc414c
Allow third party blob implementation (#629)d8f5ba0
build: disable generation of package-lock since it is not used (#623)1fe1358
test: enable --throw-deprecation for tests (#625)a35dcd1
chore(deps): address deprecated url-search-params package (#622)b3ecba5
2.4.1 release (#619)1a88481
Fix Blob for older node versions and webpack. (#618)c9805a2
2.4.0 release (#616)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.
You can always request more updates by clicking
Bump now
in your Dependabot dashboard.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard:
Finally, you can contact us by mentioning @dependabot.