Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

fix: setting x-readme-api-explorer instead of a custom UA #472

Merged
merged 1 commit into from
Feb 9, 2020

Conversation

erunion
Copy link
Member

@erunion erunion commented Feb 9, 2020

There's a bug in Firefox and Chrome where they don't respect setting a custom User-Agent on fetch() requests, so instead to let API metrics know that this request came from the Explorer, we're setting a vendor header instead.

https://stackoverflow.com/questions/42815087/sending-a-custom-user-agent-string-along-with-my-headers-fetch

Also updated fetch-har to 2.2.1 so it uses the Headers API instead of working with a bare object in the Request module.

@erunion erunion added the type:bug Something isn't working label Feb 9, 2020
@erunion erunion merged commit 4100911 into master Feb 9, 2020
@erunion erunion deleted the fix/custom-try-it-now-user-agent branch February 9, 2020 06:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant