This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
chore(deps): upgrading @readme/oas-tooling to 2.1.0 #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
type:bug
gratcliff
approved these changes
Feb 26, 2020
erunion
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades our core
@readme/oas-toolingpackage to resolve a bug where we'd allow emptydefaultproperties through on parameters and request bodies, without first looking forallowEmptyValue. The downstream effect of this was that we were happily passing along empty defaults when they shouldn't be present, resulting in API requests being made with payloads that looked as such:Check readmeio/oas#110 for more details, and comprehensive unit tests, on the fix.
Testing
I've added a new
empty-paramsdocument into our examples directory to showcase this error (and fix) in action.Before
After