This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntil compenents have a chance to lazy load
erunion
reviewed
Mar 6, 2020
erunion
added
the
type:enhancement
A potential new feature to be added, or an improvement we could make
label
Mar 6, 2020
erunion
added
type:bug
Something isn't working
and removed
type:enhancement
A potential new feature to be added, or an improvement we could make
labels
Mar 6, 2020
erunion
suggested changes
Mar 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit but otherwise looks okay to me. Deploys of the explorer are currently on hold until #436 is wrapped up, so this'll go out with that likely next week.
erunion
approved these changes
Mar 6, 2020
Will get this out next week with #436! |
@gratcliff @rafegoldberg Running this locally I'm getting the following React error:
Ideas how we can fix this? |
I'll take a look today, thanks Jon! |
erunion
pushed a commit
that referenced
this pull request
Mar 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendering workaround for anchor tags. Temporarily rendering h1 tags until components have a chance to lazy load.
https://app.asana.com/0/1163123796550394/1117151359430917