Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

fix: h1 anchor rendering #506

Merged
merged 7 commits into from
Mar 6, 2020
Merged

fix: h1 anchor rendering #506

merged 7 commits into from
Mar 6, 2020

Conversation

gratcliff
Copy link
Member

@gratcliff gratcliff commented Mar 5, 2020

Rendering workaround for anchor tags. Temporarily rendering h1 tags until components have a chance to lazy load.

https://app.asana.com/0/1163123796550394/1117151359430917

@erunion erunion added the type:enhancement A potential new feature to be added, or an improvement we could make label Mar 6, 2020
@erunion erunion changed the title fix/h1-anchor-rendering fix: h1 anchor rendering Mar 6, 2020
@erunion erunion added type:bug Something isn't working and removed type:enhancement A potential new feature to be added, or an improvement we could make labels Mar 6, 2020
@gratcliff gratcliff requested a review from erunion March 6, 2020 19:13
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but otherwise looks okay to me. Deploys of the explorer are currently on hold until #436 is wrapped up, so this'll go out with that likely next week.

packages/api-explorer/src/Doc.jsx Show resolved Hide resolved
@erunion erunion merged commit 10824e1 into master Mar 6, 2020
@erunion erunion deleted the fix/h1-anchor-rendering branch March 6, 2020 21:30
@erunion
Copy link
Member

erunion commented Mar 6, 2020

Will get this out next week with #436!

@erunion
Copy link
Member

erunion commented Mar 10, 2020

@gratcliff @rafegoldberg Running this locally I'm getting the following React error:

Warning: Cannot update during an existing state transition (such as within `render`). Render methods should be a pure function of props and state.
    in Doc
    in div
    in div
    in ApiExplorer
    in ErrorBoundary
    in Component (created by Demo)
    in div (created by Demo)
    in Demo (created by SpecFetcher)
    in SpecFetcher
    in AppContainer

Ideas how we can fix this?

@gratcliff
Copy link
Member Author

@gratcliff @rafegoldberg Running this locally I'm getting the following React error:

Warning: Cannot update during an existing state transition (such as within `render`). Render methods should be a pure function of props and state.
    in Doc
    in div
    in div
    in ApiExplorer
    in ErrorBoundary
    in Component (created by Demo)
    in div (created by Demo)
    in Demo (created by SpecFetcher)
    in SpecFetcher
    in AppContainer

Ideas how we can fix this?

I'll take a look today, thanks Jon!

erunion pushed a commit that referenced this pull request Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants