Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

fix: updating @readme/oas-tooling to 3.1.3 #545

Merged
merged 1 commit into from
Mar 20, 2020
Merged

fix: updating @readme/oas-tooling to 3.1.3 #545

merged 1 commit into from
Mar 20, 2020

Conversation

erunion
Copy link
Member

@erunion erunion commented Mar 20, 2020 •
edited
Loading

🧰 What's being changed?

This fixes two issues with how we render JSON Schema:

  • When we encounter an OAS that has type typod to array when they intended it to be object as properties and no items is present, we now reshape that as a proper object.
  • If we encounter a requestBody that has a content schema of just {}, we now ignore it as there's no information to render.

📖 Release Notes

3.1.3

  • fix: magically resolving objects that are typod as arrays #132
  • fix: don't prepare a parameter/body schema if it's empty #131

@erunion erunion added type:bug Something isn't working scope:dependency Pull requests that update a dependency file labels Mar 20, 2020
@erunion erunion merged commit b88a96b into master Mar 20, 2020
@erunion erunion deleted the fix/objects-typod-as-arrays branch March 20, 2020 23:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rafegoldberg rafegoldberg rafegoldberg approved these changes

@kanadgupta kanadgupta Awaiting requested review from kanadgupta

Assignees
No one assigned
Labels
scope:dependency Pull requests that update a dependency file type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erunion @rafegoldberg