This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
fix: using the appropriate markdown contexts when necessary #558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This resolves a bug in our Markdown processing of links where we weren't prepending the supplied
baseUrl
because, when the old Markdown processor was enabled, we were loading a context consumer that was never actually set up.What happens now is that if the new Markdown engine is enabled, we'll use the context for
BaseUrl
andGlossaryTerms
from@readme/markdown
, otherwise we'll use the same files but from@readme/markdown-engine
.🗳 Checklist