This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
fix: support for repairing malformed array schemas #560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This updates our
@readme/oas-tooling
and@readme/react-jsonschema-form
dependencies to resolve a couple issues with malformedarray
schemas:array
schema did not have anitems
property, we would fail to render the operation.array
schema had anitems
property that evaluated to{}
, we would fail to render the operation.What will happen now is if we encounter one of these malformed schemas where
items
is missing, we'll repair it and additems: {}
so that the array can be utilized as a standard mixed-data input.See readmeio/oas#138 and readmeio/react-jsonschema-form#11 for the respective fixes in
@readme/oas-tooling
and@readme/react-jsonschema-form
.🧪 Testing
Check the updates to
types.json
for the example cases.🗳 Checklist