Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

chore(markdown): Extract css build for SSRs #579

Merged
merged 33 commits into from
Apr 6, 2020
Merged

chore(markdown): Extract css build for SSRs #579

merged 33 commits into from
Apr 6, 2020

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Apr 2, 2020 •
edited
Loading

ReadMe Demo

🧰 What's being changed?

Webpack

  • extract CSS to standalone build file

Processor

  • update info callout emoji (📘)
  • regex polish
    • better callout emoji matching
    • fix compact header normalization (compact headers cannot be the first or last block in a document)

🧪 Testing

N/A

🗳 Checklist

  • 🐛 I'm fixing a bug!
  • 📸 I've made some changes to the UI!

@rafegoldberg rafegoldberg added type:bug Something isn't working type:enhancement A potential new feature to be added, or an improvement we could make labels Apr 2, 2020
@rafegoldberg rafegoldberg changed the title chore(markdown): extract css build for SSRs chore(markdown): Extract css build for SSRs Apr 2, 2020
@rafegoldberg
deps(markdown): add terser
281ef1a
@rafegoldberg
chore(markdown): set watch mode to dev explicitly
ddf56ff
@rafegoldberg
remove deprecated style imports
346eb9d
@rafegoldberg
deps(markdown): add css extract plugin
3520e09
@rafegoldberg
chore(markdown)
e248efa 
- update webpack css workflows
- move terser to main config
- disable terser minimization (for now)
@rafegoldberg
refactor(markdown): import css entry point for extraction
5e3a6d3
@rafegoldberg
build
17ab1f9
@rafegoldberg
chore(markdown): include dist in package
b95d83b
@rafegoldberg
style
b5a98b0
@rafegoldberg
chore(markdown): update regex
c26ec92
@rafegoldberg
docs
d989180
@rafegoldberg
style
95443a8
@rafegoldberg
whitelist style tags
c5395a4
@rafegoldberg
whitelist a[class] attributes
05dd980
@rafegoldberg
fix non-text heading anchor generation
915e640
@rafegoldberg
clean up base styles
be0494a 
- remove all github-related classes
- variable-ize top-level styles (fonts, colors)
@rafegoldberg
lint
9233e89
@rafegoldberg
BUILD
c9d5068
@rafegoldberg
style
47c25f3
@rafegoldberg
style(markdown): fix CSS variables
22bb330
@rafegoldberg
style(markdown): fix css variables
5057539
@rafegoldberg
style(markdown): fix GFM baseline
7773057
@rafegoldberg
ref(markdown): add [theme] attr to callout
9622549
@rafegoldberg
ref(markdown): better skin tone emoji recognition
68acd03
@rafegoldberg
fix(markdown): anchor generation when first child is not text
1e709af
@rafegoldberg
test(markdown): pass coverage thresholds
8fab981
@rafegoldberg
fix(markdown): better callout whitespace coalescing
fb104e5
@rafegoldberg rafegoldberg marked this pull request as ready for review April 6, 2020 22:16
@rafegoldberg rafegoldberg requested a review from erunion April 6, 2020 22:42
@rafegoldberg
Copy link
Contributor Author

@erunion oy vey; every time... Will revert these dist files in a sec.

@erunion
Copy link
Member

erunion commented Apr 6, 2020

If it's too much trouble, don't worry about it! They'll just get overwritten anyways when I push a new release.

@rafegoldberg
Copy link
Contributor Author

Perfect. In which case, this is ready to go whenever you give it your blessing!

@erunion erunion merged commit 738b9bc into master Apr 6, 2020
@erunion erunion deleted the rdmd/extract-css branch April 6, 2020 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
type:bug Something isn't working type:enhancement A potential new feature to be added, or an improvement we could make
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafegoldberg @erunion