Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

RDMD Feedback Fixes (2) #601

Merged
merged 18 commits into from
Apr 14, 2020
Merged

RDMD Feedback Fixes (2) #601

merged 18 commits into from
Apr 14, 2020

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Apr 14, 2020 •
edited
Loading

🧰 Changes

This PR internalizes various logics within the Unified process itself:

  • 🆕 Custom HTML magic block component (42aa00c)
  • 🐛 Compact headings parser (1b543af)
  • 🔁 Heading anchor generation (@gratcliff is gonna take care of this elsewhere)

It also includes some general clean up:

  • 🚫 Remove loose mode (in 82f17b2; deprecated by 42aa00c)
  • 🆕 Better setup method (3cb0d3f)
  • use in transformer exports
  • merge options and defaults
  • run normalization on input

See readmeio/readme#2495 for integration and ReadMe-side changes!

@rafegoldberg rafegoldberg added type:bug Something isn't working type:enhancement A potential new feature to be added, or an improvement we could make labels Apr 14, 2020
@rafegoldberg rafegoldberg marked this pull request as draft April 14, 2020 17:41
@rafegoldberg
chore(markdown): nix loose mode
82f17b2
@rafegoldberg
build
ac657e9
@rafegoldberg
chore(markdown): refactor normalization
3cb0d3f 
- nix normalize exports
- rename normalize to "setup"
- internalize option merging (defaults with user-passed config) in setup method
- use setup in every transformer method
@rafegoldberg
test(markdown): fix tests for new setup method
0228b3e
@rafegoldberg
BUILD
3c98858
@rafegoldberg rafegoldberg marked this pull request as ready for review April 14, 2020 19:23
gratcliff
gratcliff reviewed Apr 14, 2020
View reviewed changes
Copy link
Member

@gratcliff gratcliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good overall! Can you tell me more about the necessity for compactHeadings?

packages/markdown/components/Callout/index.jsx Outdated Show resolved Hide resolved
packages/markdown/components/HTMLBlock.jsx Show resolved Hide resolved
packages/markdown/index.js Show resolved Hide resolved
erunion
erunion approved these changes Apr 14, 2020
View reviewed changes
packages/markdown/components/Callout/index.jsx Outdated Show resolved Hide resolved
@rafegoldberg
Copy link
Contributor Author

dope; merging this in. @erunion can I grab a release from you? at ur convenience obviously.

@rafegoldberg rafegoldberg merged commit de94ab0 into master Apr 14, 2020
@rafegoldberg rafegoldberg deleted the rdmd/feedback-2 branch April 14, 2020 23:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gratcliff gratcliff gratcliff left review comments

@erunion erunion erunion approved these changes

Assignees
No one assigned
Labels
type:bug Something isn't working type:enhancement A potential new feature to be added, or an improvement we could make
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafegoldberg @erunion @gratcliff