This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
fix: issues preventing people from upgrading off our legacy explorer #602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This resolves a handful of issues that are preventing people from upgrading off our legacy API Explorer:
@readme/syntax-highlighter/uppercase
method. Without this, there might be a case where a language like JSON ends up in the Explorer's code tab (by way of the manual API editor example) as "json".<div className="example example_json">
.""
so we should ignore it so as to not render an empty tab in theResponseExample
component.requestBody
had atitle
ordescription
, we'd retain that text and show some orphan content. (see fix: bug where requestBody title and descriptions would come through oas#160)servers
object (something that could have been possible before we tightened down our OAS validation), we should still try to render thePathUrl
for that as@readme/oas-tooling
will set the base URL tohttps://example.com
if no server base URL is present.🗳 Checklist