RDMD Next #632
RDMD Next #632
Conversation
account for CSS var-based themes
Occasionally, authors do not add the proper line breaks between markdown blocks. Because our code tab regex was dependent on certain newline patterns, this would render some wonky shit. I cleaned up the pattern so it's now recognized entirely based on concurrent backticks! wahoo!
since this adds extra markup to acheive _such_ a simple, CSS-driven solution, we need to make sure to test this against the pertinent projects in the paper doc
dont add light box to custom emoji images
account for additional lightbox markup
lol i was wrong… we still need to check the `className` prop for the lang
class names now follow the data structure of the project.appearance.rdmd options object
…cks for tab groups
…o rdmd/next # Conflicts: # packages/api-explorer/dist/index.js # packages/markdown/dist/main.js
| <NewVariablesContext.Provider key={index} value={this.props.variables}> | ||
| <OauthContext.Provider value={this.props.oauth}> | ||
| <GlossaryTermsContext.Provider value={this.props.glossaryTerms}> | ||
| <NewGlossaryTermsContext.Provider value={this.props.glossaryTerms}> | ||
| <BaseUrlContext.Provider value={this.props.baseUrl.replace(/\/$/, '')}> | ||
| <NewBaseUrlContext.Provider value={this.props.baseUrl.replace(/\/$/, '')}> | ||
| <SelectedAppContext.Provider value={this.state.selectedApp}> |
There was a problem hiding this comment.
@erunion per some of my comments on this issue, I've double-wrapped the explorer's doc contents in both the old and new context providers. This is super verbose/redundant solution, but an interim one. I just haven't had a chance to go through and switch out all the references.
| c: 'cplusplus', | ||
| 'c++': 'cplusplus', | ||
| cpp: 'cplusplus', | ||
| docker: 'dockerfile', |
There was a problem hiding this comment.
Can you also add this to syntax-highlighter/modes.js and add a test for it to assert that docker returns the same result as dockerfile?
And since I added support for a bunch of other aliases, I'm not sure if you just want to make a new remap file in the syntax-highlighter package, or pull those in here, or what.
| @@ -0,0 +1,17 @@ | |||
| const flatMap = require('unist-util-flatmap'); | |||
|
|
|||
| // Adds an empty <div id='section-slug'> next to all headings. | |||
There was a problem hiding this comment.
Curious, but why not apply that id to the headings themselves?
There was a problem hiding this comment.
¯_(ツ)_/¯ fidlar dude
There was a problem hiding this comment.
By which I mean, obviously, that is a good suggestion.
There was a problem hiding this comment.
We could (at some point) slap the prefixed ID on the heading element itself, instead of adding it in a separate div, and leave the unprefixed one as the literal anchor icon! But Dom did this work, so not sure how difficult the HAST modification is for this. Looked pretty simple from a quick review, but.
code tabs are now delimited by an EOL char or two trailing linebreaks. this provides a more accurate match, but sometimes catches following, non-adjacent codeblocks if the intereceding linebreaks aren't appropriately authored. In these cases, we do some extra work in the parser to find and trim any trailing content from the matched syntax.
This just pulls in a bunch of commits from the RDMD project, with a few additional fixes here and there.
VariablesContextconsumer wrap