This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
fix: filter out nullish arrays from generated HAR objects #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domharrington
approved these changes
Apr 28, 2020
There was a problem hiding this comment.
Happy with this change, tested locally and it works great. Can you look into the history of why this file was added, and make sure it still carries out the original intention? I'm guessing it was fixing a similar issue with object types, but i'm not sure?
This little utility should probably be it's own npm package at this point!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This resolves a funky case with HAR generation where if a user clicks add an entry to an
array<primitive>parameter, we would immediately add[null]into their code sample.Why this was happening because if you supply
[undefined]toJSON.stringify, it'll transform that into[null], and we didn't have any work to filter out nullish items from arrays.🧪 Testing
Load up http://localhost:9966/?selected=swagger-files%2Ftypes.json, head to the "Arrays of different data types" operation and play around with adding and removing arrays.
🗳 Checklist