This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Fix RDMD callout titles. #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
approved these changes
Apr 29, 2020
| @@ -189,7 +189,8 @@ function tokenize(eat, value) { | |||
| .split(/(?:www)?\./) | |||
| .filter(i => i) | |||
| .join('')}`; | |||
| const data = { url, html, title, provider: json.provider }; | |||
| const data = { url, html, title, provider: json.provider, iframe: json.iframe }; | |||
| console.log({ json, extract: { title, url, html, data } }); | |||
There was a problem hiding this comment.
Suggested change
| console.log({ json, extract: { title, url, html, data } }); |
pass emoji icon as prop; don't include in HTML output text
rafegoldberg
force-pushed
the
fix/rdmd-callout-titles
branch
from
0708512 to
c1d3e0c
Compare
|
totally fucked on a technicality; guess I'll be eating my 🎩... |
- add default case - lightbox click event case
|
HA |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
Resolves #652.
🧪 Testing
Check it out here.
🗳 Checklist