Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Fix RDMD backwards compatible anchors. #669

Merged
merged 8 commits into from
May 1, 2020
Merged

Fix RDMD backwards compatible anchors. #669

merged 8 commits into from
May 1, 2020

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented May 1, 2020 •
edited
Loading

  • 🐛 1-to-1 with our old anchor generator
  • 🚫 remove prefixed GH slug plugin
  • 🐷 fix deprecated anchors over-scrolling

@rafegoldberg rafegoldberg added type:bug Something isn't working type:enhancement A potential new feature to be added, or an improvement we could make labels May 1, 2020
@rafegoldberg rafegoldberg requested a review from erunion May 1, 2020 18:16
@rafegoldberg rafegoldberg self-assigned this May 1, 2020
@rafegoldberg
Copy link
Contributor Author

rafegoldberg commented May 1, 2020 •
edited
Loading

Whoops, I copied the generateHeadingId() method from the old magic engine; I think the one we actually need to imitate is here, using the Lodash kebabcase method.

@rafegoldberg rafegoldberg merged commit 28a66ff into master May 1, 2020
@rafegoldberg rafegoldberg deleted the rdmd/fix-backwards-compatible-anchors branch May 1, 2020 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@domharrington domharrington domharrington left review comments

@erunion erunion erunion approved these changes

Assignees

@rafegoldberg rafegoldberg

Labels
type:bug Something isn't working type:enhancement A potential new feature to be added, or an improvement we could make
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafegoldberg @erunion @domharrington