This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
RDMD CSS theming and style adjustments. #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 🐷 add `--markdown-edge` theme variable for `<hr>`s - 🐷 clean up base styles
- 🐷 use `--border` (or `--markdown-edge`) in callout - 🐷 sub-quotes and rules inherit edge color
- 🆕 extract lightbox in to it's own component - 🆕 full keyboard accessiblity for lightboxes (traps focus for `escape`, `space`, and `enter` keys) - 🐷 fix magic block `.border` class support - 🐷 support old engine-style centering for `[width=80%]` magic images - 🐷 polish lightbox styles
rafegoldberg
added
type:enhancement
- 🐷 add `--markdown-edge` theme variable for `<hr>`s - 🐷 clean up base styles
- 🐷 use `--border` (or `--markdown-edge`) in callout - 🐷 sub-quotes and rules inherit edge color
- 🐷 kebab case `--markdown-line-height` - 🆕 add `--markdown-title-font` for section headings - 🆕 add `--md-code-font` for monospaced content
rafegoldberg
force-pushed
the
rdmd/content-style
branch
from
0f8b04a to
7820a21
Compare
# Conflicts: # packages/markdown/components/Image/index.jsx # packages/markdown/components/Image/style.scss # packages/markdown/styles/gfm.scss # packages/markdown/styles/main.scss
erunion
reviewed
May 4, 2020
packages/markdown/__tests__/__snapshots__/flavored-compilers.test.js.snap
Outdated
Show resolved
Hide resolved
Variable matching ate trailing text in plain mode. See [this conversation](https://readmeio.slack.com/archives/C04EF46CU/p1588634192333600) for initial reporting and reproduction details!
erunion
approved these changes
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This PR adds a lot of styling polish (like setting new theme variables, applying better defaults, adding various accessibility touches, further test suites, and so on) all in order to do this.
Image Blocks
Embed Blocks
Code Blocks d7a8e1a
--md-code-fontfor monospaced content (7d1635c)add default syntax highlight overrides (#673)Callouts e46edc9
--markdown-edgetheme variable for<hr>sBase Styles
--markdown-title-fontfor section headings (7d1635c)--markdown-line-height(7d1635c)--border(or--markdown-edge) in callout (de41c29)🗳 Checklist