Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Fix Firefox lightbox bug. #682

Merged
merged 2 commits into from
May 6, 2020
Merged

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented May 6, 2020

🧰 What's being changed?

This fixes a bug on Firefox where every light box would occasionally open on page load:

  • don't force state.open during initial scroll positioning
  • use generic props for light box

image


  • 🐛 I'm fixing a bug

This fixes a bug on Firefox where every lightbox would ocassionaly open on page load.

- [x] don't force `state.open` during initial scroll positioning
- [x] use generic props for lightbox
@rafegoldberg rafegoldberg added type:bug Something isn't working Markdown labels May 6, 2020
@rafegoldberg rafegoldberg merged commit 8afc8da into master May 6, 2020
@rafegoldberg rafegoldberg deleted the fix/rdmd-firefox-lightbox-bug branch May 6, 2020 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants