Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

Fix RDMD camelCase anchor splitting. #687

Merged
merged 8 commits into from
May 8, 2020

Conversation

rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented May 8, 2020

🧰 What's being changed?

  • add anchor gen test cases for camelCase scenarios
  • run backward-compatible anchor gen on node text (c2ed1dd)
    (the text value retains capitalization, where the properties.id we were kebab-ing was already lowercased.)

🗳 Checklist

  • 🐛 I'm fixing a bug

prettier is desperate to convert '\u2139\uFE0F' back to an emoji. PLEASE DON'T COMMIT THE AUTO-FIXED CHANGES WHEN YOU UPDATE TESTS OR YOU'LL BREAK README IN IE!
@rafegoldberg rafegoldberg added type:bug Something isn't working Markdown labels May 8, 2020
@rafegoldberg rafegoldberg self-assigned this May 8, 2020
@rafegoldberg rafegoldberg marked this pull request as ready for review May 8, 2020 16:09
@rafegoldberg rafegoldberg requested a review from gratcliff May 8, 2020 16:37
@gratcliff gratcliff merged commit 8f40a7e into master May 8, 2020
@gratcliff gratcliff deleted the fix/camel-cased-anchor-splitting branch May 8, 2020 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants