This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
hotfix: application/x-www-form-urlencoded bug #818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eing handled properly (#807) * test: added failing test case for formData issue I added two test cases: one for json and one for formData. The json one passes fine! This code in oas-to-har is working as expected: https://github.com/readmeio/api-explorer/blob/59a5d060997321936ae356f2ba3f36e34c81c520/packages/oas-to-har/src/index.js#L198 I narrowed down the issue to here: https://github.com/Kong/httpsnippet/blob/633b825364ab050f02556cfa837148a1e136fd69/src/index.js#L126-L128 httpsnippet is setting it from the value we set back to "" I'm not sure if this is something that's changed recently in the way we're generating hars? This part of httpsnippet hasn't been updated in 5 years. Gunna defer to Jon for this. * fix: correctly preparing `x-www-form-urlencoded` forms as params * fix: oas-to-har will now output valid HAR definitions * chore(deps): upgrading fetch-har to 3.0.0 * docs: adding an example for our handling of formData Co-authored-by: Jon Ursenbach <jon@ursenba.ch>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is extracting #807 out of
masterso it can be published to its own hotfix release.