Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

style(logs): match null state to logged-out designs #833

Merged
merged 3 commits into from
Jul 15, 2020
Merged

style(logs): match null state to logged-out designs #833

merged 3 commits into from
Jul 15, 2020

Conversation

rafegoldberg
Copy link
Contributor

🧰 What's being changed?

  • Match the <Logs/> null state to the logged-out designs.
    image

erunion
erunion approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@erunion erunion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once tests pass

kanadgupta
kanadgupta approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@kanadgupta kanadgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tiny nitpicks below but otherwise LGTM!

packages/api-logs/index.jsx Outdated Show resolved Hide resolved
packages/api-logs/main.css Outdated Show resolved Hide resolved
rafegoldberg and others added 2 commits July 15, 2020 14:36
@erunion erunion merged commit 9a6a8da into next Jul 15, 2020
@erunion erunion deleted the bld/style/logs-null-case branch July 15, 2020 22:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@erunion erunion erunion approved these changes

@kanadgupta kanadgupta kanadgupta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafegoldberg @erunion @kanadgupta