This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
fix: bug where if no securityschemes were present, we might return valid security #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erunion
added
type:bug
gratcliff
approved these changes
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This fixes a bug in our
Operation.getSecurity()code where if an API definition had a validsecuritydefinition on either an operation or the root level, we'd return that even if they didn't have anysecuritySchemesset up.This bug would expose itself by throwing a fatal error when attempting to make an API request.
See readmeio/oas#259 for the bugfix in
@readme/oas-tooling.