This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
fix: issue where polymorphism titles in refs wouldn't be surfaced #898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 What's being changed?
This fixes a bug in how we generate JSON Schema for the
Params
component where under certain conditions,title
properties on polymorphism schemas (oneOf
,anyOf
, andallOf
) would be deleted.This also patches in a workaround for a bug in RJSF where if a
title
property is within a$ref
and not at the level of the$ref
, it wouldn't be used when constructing a dropdown for the schemas, instead displaying a placeholder label of "Option 1". Bug ticketed here.🧪 Testing
You can see this bug in action here: http://bin.readme.com/s/5f46ce04c46abe00244f41f6
Though the
Cat
andDog
schemas have atitle
property, it's not used in the dropdown.With this fix, it now looks like: