Skip to content

Commit 774407d

Browse files
erunionkanadgupta
andauthored
feat: adding support for node 18 (#495)
* feat: adding support for node 18 * test: fixing a broken test * chore: update comment Comment now reflects what the `engines.node` field looks like Co-authored-by: Kanad Gupta <kgupta@umn.edu>
1 parent d331343 commit 774407d

File tree

5 files changed

+265
-300
lines changed

5 files changed

+265
-300
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,10 @@ jobs:
88
runs-on: ubuntu-latest
99
strategy:
1010
matrix:
11-
node-version: [14.x, 16.x, 17.x]
11+
node-version:
12+
- 14
13+
- 16
14+
- 18
1215

1316
steps:
1417
- uses: actions/checkout@v3

__tests__/lib/isSupportedNodeVersion.test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@ describe('#isSupportedNodeVersion()', () => {
44
it('should return true for a supported version of node', () => {
55
expect(isSupportedNodeVersion('14.5.1')).toBe(true);
66
expect(isSupportedNodeVersion('16.0.0')).toBe(true);
7+
expect(isSupportedNodeVersion('18.0.0')).toBe(true);
78
});
89

910
it('should return false for an unsupported version of node', () => {
1011
expect(isSupportedNodeVersion('10.0.0')).toBe(false);
1112
expect(isSupportedNodeVersion('12.0.0')).toBe(false);
12-
expect(isSupportedNodeVersion('18.0.0')).toBe(false);
1313
});
1414
});

0 commit comments

Comments
 (0)