fix(openapi): type fixes in prepareOas
#1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanadgupta
added
bug
kanadgupta
commented
Jan 6, 2025
| @@ -213,7 +209,9 @@ export default async function prepareOas( | |||
| const specVersion: string = api.info.version; | |||
| debug(`version in spec: ${specVersion}`); | |||
|
|
|||
| if (['openapi', 'openapi inspect', 'openapi reduce'].includes(command)) { | |||
| const commandsThatBundle: (typeof command)[] = ['openapi inspect', 'openapi reduce', 'openapi upload']; | |||
There was a problem hiding this comment.
🧐 do we want to bundle by default for openapi upload? see #1142
There was a problem hiding this comment.
i think we have to because if we don't then they might upload an invalid spec that has ref pointers to a local file
erunion
approved these changes
Jan 6, 2025
kanadgupta
pushed a commit
that referenced
this pull request
Jan 6, 2025
# [10.1.0-next.3](v10.1.0-next.2...v10.1.0-next.3) (2025-01-06) ### Bug Fixes * **openapi:** type fixes in `prepareOas` ([#1141](#1141)) ([fc55d28](fc55d28)) [skip ci]
|
🎉 This PR is included in version 10.1.0-next.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
7 tasks
kanadgupta
added a commit
that referenced
this pull request
Jan 6, 2025
when reviewing #1126, i noticed a few small bugs in our `prepareOas` helper function. this PR makes a few typesafety improvements so we shouldn't run into this issue again(?) ~~one outstanding question that i'd like to figure out prior to merge, see #1142 (**edit**: going to continue bundling and handle this issue in a follow-up PR) do tests + types pass?
kanadgupta
pushed a commit
that referenced
this pull request
Jan 6, 2025
kanadgupta
added a commit
that referenced
this pull request
Jan 6, 2025
## 🧰 Changes reapplies the following changes from the `next` branch onto the `v9` branch: - [x] #1124 - [x] #1125 - [x] #1126 - [x] #1127 - [x] #1143 - [x] #1144 - [x] #1141 ## 🧬 QA & Testing do tests pass? --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jon Ursenbach <erunion@users.noreply.github.com> Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net> Co-authored-by: Jon Ursenbach <jon@ursenba.ch> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
kanadgupta
pushed a commit
that referenced
this pull request
Jan 14, 2025
# [10.1.0](v10.0.0...v10.1.0) (2025-01-14) ### Bug Fixes * **openapi:** type fixes in `prepareOas` ([#1141](#1141)) ([fc55d28](fc55d28)) ### Features * **openapi:** a fresh coat of paint on `openapi inspect` ([#1127](#1127)) ([ff8c304](ff8c304)) * **openapi:** tooling upgrades ([#1126](#1126)) ([6678d68](6678d68)) * **v9:** backport openapi tooling etc. from v10 ([#1145](#1145)) ([14828db](14828db)) [skip ci]
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
when reviewing #1126, i noticed a few small bugs in our
prepareOashelper function. this PR makes a few typesafety improvements so we shouldn't run into this issue again(?)one outstanding question that i'd like to figure out prior to merge, see #1142(edit: going to continue bundling and handle this issue in a follow-up PR)🧬 QA & Testing
do tests + types pass?